Skip to content

Remove dataset consolidate #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

Remove dataset consolidate #752

merged 1 commit into from
Feb 19, 2025

Conversation

aliberts
Copy link
Collaborator

@aliberts aliberts commented Feb 19, 2025 •
edited
Loading

What this does

Consolidate was doing 3 things:

  • Encoding videos from remaining images (if any) that were not encoded during save_episode -> Video are automatically encoded during save_episode
  • Perform various sanity checks (number of files, timestamps sync) -> moved to save_episode
  • Compute statistics -> Removed by Per-episode stats #521

How it was tested

Normal testing suite

@aliberts aliberts changed the base branch from main to user/aliberts/2025_02_10_dataset_v2.1 February 19, 2025 12:23
@aliberts aliberts mentioned this pull request Feb 19, 2025
Merged
3 tasks
@aliberts aliberts marked this pull request as ready for review February 19, 2025 12:36
@aliberts aliberts requested a review from Cadene February 19, 2025 12:41
Cadene
Cadene approved these changes Feb 19, 2025
View reviewed changes
Copy link
Collaborator

@Cadene Cadene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@aliberts aliberts merged commit 969ef74 into user/aliberts/2025_02_10_dataset_v2.1 Feb 19, 2025
5 checks passed
@aliberts aliberts deleted the user/aliberts/2025_02_19_rm_consolidate branch February 19, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cadene Cadene Cadene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aliberts @Cadene