Fix: wrap homing_offset to 12-bit signed range (-2048..2047) for grip… #1885
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per motors from partabot Wrap homing_offset into 12-bit signed range before write Wrap homing_offset into 12-bit signed range before write
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…per motors from partabot
Wrap homing_offset into 12-bit signed range before write
What this does
On the partabot FeeTech gripper servo it reports values that are outside of the allowed range. This normalizes the values to a 12 bit range and fixes issues with overflowing the vartiable
How it was tested
I ran this before and after the fix. The before calibration step shows the gripper in values beyond 12 bit as seen in the picture below
How to checkout & try? (for the reviewer)
Calibrate a leader arm and see the values fall within the range