This repository was archived by the owner on Jun 11, 2022. It is now read-only.
John conroy/jest #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccalluc
approved these changes
Jan 8, 2021
| transform: { | ||
| '^.+\\.(ts)$': 'ts-jest', | ||
| }, | ||
| }; |
There was a problem hiding this comment.
All these PRs have a lot of bootstrapping: They all seems reasonable, but if I were to come back to it, I'd be hard-pressed to to say what the motivation for any particular choice is. If there are any corners that aren't just obviously the right thing to do, commenting in the PR or the file iteself could helpful. (something like: "Configuration from the tutorial at this url ..." / "Configuration based on this stackoverflow ..." / "Configuration generated by this init command...")
Use your judgement.
Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>
john-conroy
added a commit
that referenced
this pull request
Jan 11, 2021
* Install rollup and rollup-plugin-typescript2 * Add rollup config * Add eslintignore and ignore dist * Add entries in package.json for esm and cjs and build script * Add include and exclude to tsconfig * Add example index.ts * John conroy/jest (#5) * Install jest, @types/jest and ts-jest * Add test scripts to package.json * Add jest config * Install eslint import plugins * Configure eslint import plugins * Configure eslint for jest * Add example file * Add example test * Add types to example file and test * Exclude tests in tsconfig * Add github actions ci (#6) Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>
john-conroy
added a commit
that referenced
this pull request
Jan 11, 2021
* Initialize npm and install eslint * Initialize eslint * Install typescript * Initialize typescript * Install prettier and plugins * Update eslint config * Add prettier yml * Add lint scripts * John conroy/rollup (#3) * Install rollup and rollup-plugin-typescript2 * Add rollup config * Add eslintignore and ignore dist * Add entries in package.json for esm and cjs and build script * Add include and exclude to tsconfig * Add example index.ts * John conroy/jest (#5) * Install jest, @types/jest and ts-jest * Add test scripts to package.json * Add jest config * Install eslint import plugins * Configure eslint import plugins * Configure eslint for jest * Add example file * Add example test * Add types to example file and test * Exclude tests in tsconfig * Add github actions ci (#6) Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> * John conroy/husky lint staged (#2) * Install husky and lint-staged * Add husky and lint-staged Co-authored-by: John Conroy <john-conroy@users.noreply.github.com> Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup jest, add eslint import resolver and add example test.