Skip to content
This repository was archived by the owner on Jun 11, 2022. It is now read-only.

Conversation

john-conroy
Copy link
Collaborator

Adds lint staged and husky to lint, but not fix, and prettier write on each commit.

@john-conroy john-conroy requested a review from mccalluc January 8, 2021 20:42
@mccalluc
Copy link
Contributor

mccalluc commented Jan 8, 2021

It looks like pretty much the same settings as portal-ui? I think that's good: If we want to try something new in one repo (like the typescript) I think that's great, but in the longer-term we want to have the same kinds of patterns across our repos. Thanks!

@john-conroy john-conroy merged commit 42bf26f into john-conroy/typescript-eslint-prettier Jan 11, 2021
@john-conroy john-conroy deleted the john-conroy/husky-lint-staged branch January 11, 2021 15:13
john-conroy added a commit that referenced this pull request Jan 11, 2021
* Initialize npm and install eslint

* Initialize eslint

* Install typescript

* Initialize typescript

* Install prettier and plugins

* Update eslint config

* Add prettier yml

* Add lint scripts

* John conroy/rollup (#3)

* Install rollup and rollup-plugin-typescript2

* Add rollup config

* Add eslintignore and ignore dist

* Add entries in package.json for esm and cjs and build script

* Add include and exclude to tsconfig

* Add example index.ts

* John conroy/jest (#5)

* Install jest, @types/jest and ts-jest

* Add test scripts to package.json

* Add jest config

* Install eslint import plugins

* Configure eslint import plugins

* Configure eslint for jest

* Add example file

* Add example test

* Add types to example file and test

* Exclude tests in tsconfig

* Add github actions ci (#6)

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>

* John conroy/husky lint staged (#2)

* Install husky and lint-staged

* Add husky and lint-staged

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>

Co-authored-by: John Conroy <john-conroy@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants