Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Knocki documentation #33256

Merged
merged 5 commits into from
Jun 24, 2024
Merged

Add Knocki documentation #33256

merged 5 commits into from
Jun 24, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Jun 13, 2024

Proposed change

Add Knocki documentation

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Added instructions on setting up Knocki devices in Home Assistant to receive events triggered by these devices.

@home-assistant home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch labels Jun 13, 2024
Copy link
Contributor

coderabbitai bot commented Jun 13, 2024

Walkthrough

Walkthrough

This update introduces instructions on setting up Knocki devices in Home Assistant, enabling the integration to receive events triggered by these devices. The changes are purely instructional and do not involve any modifications to the declarations of exported or public entities.

Changes

File Change Summary
source/_integrations/knocki.markdown Added guidance on configuring Knocki devices in Home Assistant to handle events triggered by these devices.

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between cf6baf1 and 3a7bbfb.

Files selected for processing (1)
  • source/_integrations/knocki.markdown (1 hunks)
Additional context used
LanguageTool
source/_integrations/knocki.markdown

[misspelling] ~18-~18: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ntegration_type: integration --- The Knocki {% term integration %} can receive ev...


[misspelling] ~18-~18: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ents for the triggers set up from your Knocki devices. ## Prer...


[misspelling] ~22-~22: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ki.com/). ## Prerequisites To use the Knocki integration, you need a Knocki account....


[misspelling] ~22-~22: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ... use the Knocki integration, you need a Knocki account. Once you set a trigger in the...

Additional comments not posted (3)
source/_integrations/knocki.markdown (3)

1-16: Metadata setup looks correct.

The metadata fields such as title, description, ha_category, and others are appropriately set up for the new integration documentation.


18-18: Introduction is clear and concise.

The introductory sentence effectively communicates the functionality of the Knocki integration. The term "Knocki" is correctly used here, and the apparent misspelling flagged by static analysis is a false positive.

Tools
LanguageTool

[misspelling] ~18-~18: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ntegration_type: integration --- The Knocki {% term integration %} can receive ev...


[misspelling] ~18-~18: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ents for the triggers set up from your Knocki devices. ## Prer...


20-24: Enhance clarity and grammar in the prerequisites section.

The prerequisites section can be made more concise and clear. There's also a hint about a possible missing comma which should be addressed to improve readability.

- To use the Knocki integration, you need a Knocki account.
+ To use the Knocki integration, you need a Knocki account.

Likely invalid or redundant comment.

Tools
LanguageTool

[misspelling] ~22-~22: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ...ki.com/). ## Prerequisites To use the Knocki integration, you need a Knocki account....


[misspelling] ~22-~22: Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Context: ... use the Knocki integration, you need a Knocki account. Once you set a trigger in the...


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 3a7bbfb
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/6679141854e1920008061976
😎 Deploy Preview https://deploy-preview-33256--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@c0ffeeca7 c0ffeeca7 added the new-integration This PR adds documentation for a new Home Assistant integration label Jun 17, 2024
---

The **Knocki** {% term integration %} can receive events for the triggers set up from your [Knocki devices](https://knocki.com/).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any prerequisites? For example: Do I need a Knocki account and login credentials when adding the integration?

@c0ffeeca7 c0ffeeca7 marked this pull request as draft June 20, 2024 03:59
@edenhaus edenhaus added the parent-merged The parent PR has been merged already label Jun 21, 2024
@joostlek
Copy link
Member Author

Usually I am a bit more verbal, but in this case I don't have a lot of words haha

@joostlek joostlek marked this pull request as ready for review June 23, 2024 15:31
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

source/_integrations/knocki.markdown Outdated Show resolved Hide resolved
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @joostlek 👍

@c0ffeeca7
Copy link
Contributor

@joostlek, can you take a look at the related brand PR?

@frenck
Copy link
Member

frenck commented Jun 24, 2024

Pinged Joost about the brands, merging this one in to I can start working on rc.

@frenck frenck merged commit 941b52c into home-assistant:next Jun 24, 2024
6 checks passed
@home-assistant home-assistant bot removed the parent-merged The parent PR has been merged already label Jun 24, 2024
@joostlek joostlek deleted the knocki branch June 24, 2024 06:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants