Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Knocki integration #119140

Merged
merged 19 commits into from
Jun 21, 2024
Merged

Add Knocki integration #119140

merged 19 commits into from
Jun 21, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Jun 8, 2024

Proposed change

SSIA

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@joostlek joostlek marked this pull request as ready for review June 13, 2024 17:01
homeassistant/components/knocki/config_flow.py Outdated Show resolved Hide resolved
self._abort_if_unique_id_configured()
client.token = token_response.token
try:
await client.link()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it throws with the exact same reasons why not move this to the previous try: and save some duplicate code?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this shouldn't be called if the unique_id is already configured, but moving the unique_id setting and abort to the try block felt strange as well

Co-authored-by: Josef Zweck <24647999+zweckj@users.noreply.github.com>
CODEOWNERS Outdated Show resolved Hide resolved
homeassistant/components/knocki/manifest.json Outdated Show resolved Hide resolved
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure CI is passing

homeassistant/components/knocki/event.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 20, 2024 08:17
@joostlek joostlek marked this pull request as ready for review June 20, 2024 09:25
@home-assistant home-assistant bot requested a review from edenhaus June 20, 2024 09:25
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joostlek 👍

@edenhaus edenhaus merged commit 2770811 into home-assistant:dev Jun 21, 2024
39 checks passed
@joostlek joostlek deleted the knocki branch June 22, 2024 11:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants