Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Knocki logos #5578

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Add Knocki logos #5578

merged 4 commits into from
Jun 24, 2024

Conversation

joostlek
Copy link
Member

@joostlek joostlek commented Jun 13, 2024

Proposed change

Add Knocki logos

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for (icon@2x.png)
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side (logo@2x.png)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo labels Jun 14, 2024
@frenck frenck added the parent-merged The parent PR has been merged already label Jun 21, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, @joostlek... Turns out the CI was failing. Could you take a look?

Thanks! 👍

../Frenck

@home-assistant home-assistant bot marked this pull request as draft June 21, 2024 16:56
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek marked this pull request as ready for review June 24, 2024 06:49
@home-assistant home-assistant bot requested a review from frenck June 24, 2024 06:49
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @joostlek 👍

../Frenck

@frenck frenck merged commit 1354713 into home-assistant:master Jun 24, 2024
5 checks passed
Athozs pushed a commit to Athozs/brands that referenced this pull request Aug 30, 2024
Co-authored-by: Robert Resch <robert@resch.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo parent-merged The parent PR has been merged already
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants