Add Iotty #29624

pburgio · 2023-10-31T11:42:08Z

Proposed change

Type of change

Spelling, grammar or other readability improvements (current branch).
Adjusted missing or incorrect information in the current documentation (current branch).
Added documentation for a new integration I'm adding to Home Assistant (next branch).
- I've opened up a PR to add logo's and icons in Brands repository.
Added documentation for a new feature I'm adding to Home Assistant (next branch).
Removed stale or deprecated documentation.

Additional information

Link to parent pull request in the codebase: Add integration for iotty Smart Home core#103073
Link to parent pull request in the Brands repository: Added icons for iotty Core Integration brands#4966
This PR fixes or closes issue: fixes #

Checklist

This PR uses the correct branch, based on one of the following:
- I made a change to the existing documentation and used the current branch.
- I made a change that is related to an upcoming version of Home Assistant and used the next branch.
The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

New Features
- Introduced comprehensive documentation for integrating iotty smart devices with Home Assistant, enhancing user experience and installation ease.
- Detailed instructions for connecting devices such as Smart Switch, Smart Shades Switch, and Smart Outlet, including links to US and EU versions.
Documentation
- Added a new markdown file that serves as a crucial resource for users looking to incorporate iotty devices into their Home Assistant setup.

home-assistant · 2023-10-31T11:42:12Z

It seems that this PR is targeted against an incorrect branch. Documentation updates which apply to our current stable release should target the current branch. Please change the target branch of this PR to current and rebase if needed. If this is documentation for a new feature, please add a link to that PR in your description.

home-assistant · 2023-11-02T15:00:08Z

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

coderabbitai

Actionable comments posted: 1

Outside diff range, codebase verification and nitpick comments (1)

source/_integrations/iotty.markdown (1)

14-14: Improve readability of the introductory paragraph.

Consider rephrasing for better readability:

- The iotty family is focused on beautiful aesthetics and includes the Smart Switch for lights and gates, the Smart Shades Switch for blinds and shutters and the Smart Outlet. Install the iotty devices and enjoy your new Smart Home with ease!
+ The iotty family focuses on beautiful aesthetics and includes the Smart Switch for lights and gates, the Smart Shades Switch for blinds and shutters, and the Smart Outlet. Install iotty devices and enjoy your new Smart Home with ease!

coderabbitai · 2024-07-19T12:09:04Z

source/_integrations/iotty.markdown

+
+More integrations are coming soon:


Remove multiple consecutive blank lines.

There are multiple consecutive blank lines that should be removed for better readability.

- +

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

More integrations are coming soon:

More integrations are coming soon:

Tools

Markdownlint

32-32: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

Discarded, as this is no longer present in the documentation

@shapournemati-iotty Thank you for the update. I have verified the latest content of the source/_integrations/iotty.markdown file, and it confirms that the issue of multiple consecutive blank lines has been resolved. No further action is needed.

Analysis chain

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash # Display the content of the `source/_integrations/iotty.markdown` file to verify the absence of multiple consecutive blank lines. cat source/_integrations/iotty.markdown

Length of output: 2171

source/_integrations/iotty.markdown

c0ffeeca7 · 2024-07-19T12:11:23Z

source/_integrations/iotty.markdown

+  - https://iotty.fr/collections/frontpage/products/prise-intelligent-iotty
+  - https://iotty.de/collections/frontpage/products/iotty-smart-steckdose
+  - https://iotty.it/collections/frontpage/products/iotty-plus-presa-intelligente
+


Are there any prerequisites? Anything I need to do or have before I can install the iotty integration, for example, do I need an iotty account and login credentials?

source/_integrations/iotty.markdown

https://github.com/home-assistant/core/pull/103073/files#diff-42fa91b71097e4c7eebdd723fe0c616a86d1356ac85186fc4ed4adad918bd2d9R1

source/_integrations/iotty.markdown

c0ffeeca7 · 2024-07-19T12:39:18Z

source/_integrations/iotty.markdown

+  EU VERSION:
+  - https://iotty.fr/collections/frontpage/products/prise-intelligent-iotty
+  - https://iotty.de/collections/frontpage/products/iotty-smart-steckdose
+  - https://iotty.it/collections/frontpage/products/iotty-plus-presa-intelligente


Please add a section that gives more information about the supported entities. For example, Husquvarna or La Marzocco have sections on switches, for reference.

In our integration things are pretty simple: one switch per device. I have added a small section about that, let me know if that is what you were thinking about

source/_integrations/iotty.markdown

c0ffeeca7 · 2024-07-19T12:46:48Z

source/_integrations/iotty.markdown

+  - https://iotty.it/collections/frontpage/products/iotty-plus-interruttore-intelligente-per-luci-e-cancelli
+
+
+More integrations are coming soon:


Suggested change

More integrations are coming soon:

c0ffeeca7 · 2024-07-19T12:47:33Z

source/_integrations/iotty.markdown

+
+- iotty Shades Switch \
+  EU VERSION:
+  - https://iotty.uk/collections/frontpage/products/iotty-smart-shades-switch
+  - https://iotty.it/collections/frontpage/products/iotty-plus-interruttore-intelligente-per-tende-e-tapparelle
+
+- iotty Smart Outlet: \
+  EU VERSION:
+  - https://iotty.fr/collections/frontpage/products/prise-intelligent-iotty
+  - https://iotty.de/collections/frontpage/products/iotty-smart-steckdose
+  - https://iotty.it/collections/frontpage/products/iotty-plus-presa-intelligente


Suggested change

- iotty Shades Switch \

EU VERSION:

- https://iotty.uk/collections/frontpage/products/iotty-smart-shades-switch

- https://iotty.it/collections/frontpage/products/iotty-plus-interruttore-intelligente-per-tende-e-tapparelle

- iotty Smart Outlet: \

EU VERSION:

- https://iotty.fr/collections/frontpage/products/prise-intelligent-iotty

- https://iotty.de/collections/frontpage/products/iotty-smart-steckdose

- https://iotty.it/collections/frontpage/products/iotty-plus-presa-intelligente

I think the documentation should focus on the current status.

I agree, it has been removed

source/_integrations/iotty.markdown

…upported entities descriptions

c0ffeeca7

Tiny tweaks

source/_integrations/iotty.markdown

c0ffeeca7 · 2024-07-22T12:29:50Z

source/_integrations/iotty.markdown

+
+## Supported entities
+
+Each iotty device gets mapped into one Home Assistant device per gang, each with its own Switch entity.


what do you mean by "per gang"? group?

Hi, "gang" is a pretty standard term used when referring to te single switches on a plate, as you can see in this wikipedia article: Light Switch.

I didn't want to reuse the word "Device" or "Switch" as it would be using the same word to define itself. Let me know if that is clear, or if you have any other suggestion to replace the word "gang"

Thank you for the explanation. Learned something today.

c0ffeeca7

Thank you, @pburgio and @shapournemati-iotty 👍

MartinHjelmare · 2024-07-22T15:23:05Z

source/_integrations/iotty.markdown

+
+### Switches
+
+The main, unnamed, switch entity controls the light switch, turning it on or off the gang related to it.


This sentence has incorrect grammar. I can't make a suggestion since it's not clear to me what meaning is meant.

Hej Martin, thanks for the feedback. Since the PR has already been merged, what is the suggested course of action here? Open another PR to fix this? Wait for the next release in which some functionality will be added to my integration?

For what concerns the meaning, what I want to convey is:

There is only one entity per device

The main (and only) entity of the device is unnamed

The switch entity is meant to control a light switch

Please open a new PR and adjust the sentence.

Added iotty documentation

7e32b5b

pburgio requested review from joostlek, chemelli74, allenporter, a team and fabaff as code owners October 31, 2023 11:42

home-assistant bot assigned pburgio Oct 31, 2023

pburgio changed the base branch from next to current October 31, 2023 11:43

home-assistant bot removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch next This PR goes into the next branch labels Oct 31, 2023

home-assistant bot unassigned pburgio Oct 31, 2023

home-assistant bot added the current This PR goes into the current branch label Oct 31, 2023

Merge branch 'current' into iotty-initial-docs

f42e0b7

pburgio mentioned this pull request Nov 2, 2023

Added icons for iotty Core Integration home-assistant/brands#4845

Closed

11 tasks

home-assistant bot assigned pburgio Nov 2, 2023

home-assistant bot added has-parent This PR has a parent PR in a other repo needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 2, 2023

pburgio changed the base branch from current to next November 2, 2023 16:30

home-assistant bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Nov 2, 2023

home-assistant bot unassigned pburgio Nov 2, 2023

home-assistant bot added the next This PR goes into the next branch label Nov 2, 2023

pburgio added 2 commits November 2, 2023 17:30

Merge branch 'next' into iotty-initial-docs

ef8c5c3

Merge branch 'next' into iotty-initial-docs

1018c53

coderabbitai bot reviewed Jul 19, 2024

View reviewed changes

c0ffeeca7 reviewed Jul 19, 2024

View reviewed changes

source/_integrations/iotty.markdown Show resolved Hide resolved

add platform and integrration type to header

25e8a08

c0ffeeca7 reviewed Jul 19, 2024

View reviewed changes

source/_integrations/iotty.markdown Outdated Show resolved Hide resolved

Update source/_integrations/iotty.markdown

fdf3988

c0ffeeca7 reviewed Jul 19, 2024

View reviewed changes

source/_integrations/iotty.markdown Outdated Show resolved Hide resolved

Add switch to category

3bebbe0

https://github.com/home-assistant/core/pull/103073/files#diff-42fa91b71097e4c7eebdd723fe0c616a86d1356ac85186fc4ed4adad918bd2d9R1

c0ffeeca7 reviewed Jul 19, 2024

View reviewed changes

source/_integrations/iotty.markdown Outdated Show resolved Hide resolved

c0ffeeca7 reviewed Jul 19, 2024

View reviewed changes

source/_integrations/iotty.markdown Outdated Show resolved Hide resolved

source/_integrations/iotty.markdown Outdated Show resolved Hide resolved

source/_integrations/iotty.markdown Show resolved Hide resolved

move config_flow up

37d45fe

c0ffeeca7 reviewed Jul 19, 2024

View reviewed changes

c0ffeeca7 marked this pull request as draft July 19, 2024 12:39

Update source/_integrations/iotty.markdown

60ecac0

c0ffeeca7 reviewed Jul 19, 2024

View reviewed changes

source/_integrations/iotty.markdown Outdated Show resolved Hide resolved

Update source/_integrations/iotty.markdown

1c45070

c0ffeeca7 requested changes Jul 19, 2024

View reviewed changes

shapournemati-iotty added 2 commits July 22, 2024 14:18

Add prerequisites, fix links so they are in markdown style, and add s…

cfa07b3

…upported entities descriptions

fix spelling of Home Assistant

c5df637

c0ffeeca7 requested changes Jul 22, 2024

View reviewed changes

Apply suggestions from code review

b134bd3

c0ffeeca7 reviewed Jul 22, 2024

View reviewed changes

pburgio marked this pull request as ready for review July 22, 2024 13:51

Merge branch 'next' into iotty-initial-docs

9ddeb8b

c0ffeeca7 approved these changes Jul 22, 2024

View reviewed changes

c0ffeeca7 merged commit 99b2d1f into home-assistant:next Jul 22, 2024
6 checks passed

home-assistant bot removed in-progress This PR/Issue is currently being worked on parent-merged The parent PR has been merged already labels Jul 22, 2024

MartinHjelmare reviewed Jul 22, 2024

View reviewed changes

github-actions bot locked and limited conversation to collaborators Jul 23, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Iotty #29624

Add Iotty #29624

pburgio commented Oct 31, 2023 •

edited by coderabbitai bot

Loading

home-assistant bot commented Oct 31, 2023

home-assistant bot commented Nov 2, 2023

coderabbitai bot left a comment

coderabbitai bot Jul 19, 2024 •

edited

Loading

shapournemati-iotty Jul 22, 2024

coderabbitai bot Jul 22, 2024

c0ffeeca7 Jul 19, 2024

shapournemati-iotty Jul 22, 2024

c0ffeeca7 Jul 19, 2024

shapournemati-iotty Jul 22, 2024

c0ffeeca7 Jul 19, 2024

shapournemati-iotty Jul 22, 2024

c0ffeeca7 Jul 19, 2024

shapournemati-iotty Jul 22, 2024

c0ffeeca7 left a comment

c0ffeeca7 Jul 22, 2024 •

edited

Loading

shapournemati-iotty Jul 22, 2024

c0ffeeca7 Jul 22, 2024

c0ffeeca7 left a comment •

edited

Loading

MartinHjelmare Jul 22, 2024

shapournemati-iotty Jul 22, 2024

MartinHjelmare Jul 22, 2024


	More integrations are coming soon:

	More integrations are coming soon:

		- https://iotty.it/collections/frontpage/products/iotty-plus-interruttore-intelligente-per-luci-e-cancelli


		More integrations are coming soon:


		## Supported entities

		Each iotty device gets mapped into one Home Assistant device per gang, each with its own Switch entity.


		### Switches

		The main, unnamed, switch entity controls the light switch, turning it on or off the gang related to it.

Add Iotty #29624

Add Iotty #29624

Conversation

pburgio commented Oct 31, 2023 • edited by coderabbitai bot Loading

Proposed change

Type of change

Additional information

Checklist

Summary by CodeRabbit

home-assistant bot commented Oct 31, 2023

home-assistant bot commented Nov 2, 2023

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Jul 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coderabbitai bot Jul 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c0ffeeca7 left a comment

Choose a reason for hiding this comment

c0ffeeca7 Jul 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

c0ffeeca7 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pburgio commented Oct 31, 2023 •

edited by coderabbitai bot

Loading

coderabbitai bot Jul 19, 2024 •

edited

Loading

c0ffeeca7 Jul 22, 2024 •

edited

Loading

c0ffeeca7 left a comment •

edited

Loading