Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration for iotty Smart Home #103073

Merged
merged 137 commits into from
Jul 19, 2024
Merged

Add integration for iotty Smart Home #103073

merged 137 commits into from
Jul 19, 2024

Conversation

pburgio
Copy link
Contributor

@pburgio pburgio commented Oct 30, 2023

Breaking change

Proposed change

This is the first implementation of Hass support to iotty Smart Devices

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pburgio

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@pburgio pburgio marked this pull request as ready for review October 30, 2023 16:04
@jpbede jpbede changed the title Added first PR for Iotty Smart Devices Add integration for iotty Smart Devices Oct 30, 2023
@jpbede
Copy link
Member

jpbede commented Oct 30, 2023

Please also add the integration to the documentation and link it here.

homeassistant/components/iotty/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/iotty/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/iotty/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/iotty/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/iotty/switch.py Outdated Show resolved Hide resolved
@pburgio
Copy link
Contributor Author

pburgio commented Nov 5, 2023

Please also add the integration to the documentation and link it here.

Opened a PR for that. All checks passed. Waiting for approval
link

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 6, 2024
homeassistant/components/iotty/const.py Outdated Show resolved Hide resolved
homeassistant/components/iotty/const.py Outdated Show resolved Hide resolved
homeassistant/components/iotty/const.py Outdated Show resolved Hide resolved
homeassistant/components/iotty/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/iotty/switch.py Outdated Show resolved Hide resolved
tests/components/iotty/conftest.py Outdated Show resolved Hide resolved
tests/components/iotty/test_api.py Outdated Show resolved Hide resolved
tests/components/iotty/test_api.py Outdated Show resolved Hide resolved
tests/components/iotty/test_api.py Outdated Show resolved Hide resolved
tests/components/iotty/test_init.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 10, 2024 11:30
@pburgio pburgio marked this pull request as ready for review July 11, 2024 05:55
tests/components/iotty/test_api.py Outdated Show resolved Hide resolved
tests/components/iotty/test_api.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 17, 2024 07:27
@emontnemery
Copy link
Contributor

There are a few uncovered lines, mostly related to error handling when we fail to get data from the remote API. Can we add some tests which cover that?

@pburgio pburgio marked this pull request as ready for review July 18, 2024 12:27
tests/components/iotty/test_api.py Outdated Show resolved Hide resolved
tests/components/iotty/test_switch.py Outdated Show resolved Hide resolved
tests/components/iotty/test_switch.py Outdated Show resolved Hide resolved
tests/components/iotty/test_switch.py Outdated Show resolved Hide resolved
tests/components/iotty/test_switch.py Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft July 19, 2024 07:21
@emontnemery emontnemery marked this pull request as ready for review July 19, 2024 08:07
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pburgio , @shapournemati-iotty 👍

@emontnemery emontnemery merged commit c1c5cff into home-assistant:dev Jul 19, 2024
36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-tests integration: iotty new-integration smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants