Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Iotty #29624
Add Iotty #29624
Changes from 17 commits
7e32b5b
f42e0b7
ef8c5c3
1018c53
241037c
fddea58
b6f1b32
2f2eee3
656da8c
dfdc39e
764d12e
a119543
df481b4
6abce65
d811a11
97c04ed
25e8a08
fdf3988
3bebbe0
37d45fe
60ecac0
1c45070
cfa07b3
c5df637
b134bd3
9ddeb8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convert bare URLs to markdown links and add missing punctuation.
Bare URLs should be converted to markdown links for better readability. Additionally, add a colon after "EU VERSION:" for consistency.
Committable suggestion
Tools
LanguageTool
Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shapournemati-iotty Thank you for making the changes! If there's anything else you need assistance with, feel free to let me know. 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove multiple consecutive blank lines.
There are multiple consecutive blank lines that should be removed for better readability.
Committable suggestion
Tools
Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discarded, as this is no longer present in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shapournemati-iotty Thank you for the update. I have verified the latest content of the
source/_integrations/iotty.markdown
file, and it confirms that the issue of multiple consecutive blank lines has been resolved. No further action is needed.Analysis chain
Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 2171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convert bare URLs to markdown links and add missing punctuation.
Bare URLs should be converted to markdown links for better readability. Additionally, add a colon after "EU VERSION:" for consistency.
Committable suggestion
Tools
LanguageTool
Markdownlint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discarded, as this is no longer present in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shapournemati-iotty Thank you for the update. I have reviewed the current state of the
source/_integrations/iotty.markdown
file, and it appears that the URLs have already been converted to markdown links. The initial suggestion is no longer necessary as the changes have been addressed in the latest version of the documentation.If you need any further assistance, feel free to let me know!
Analysis chain
Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 2171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a section that gives more information about the supported entities. For example, Husquvarna or La Marzocco have sections on switches, for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our integration things are pretty simple: one switch per device. I have added a small section about that, let me know if that is what you were thinking about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the documentation should focus on the current status.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it has been removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any prerequisites? Anything I need to do or have before I can install the iotty integration, for example, do I need an iotty account and login credentials?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done