Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esphome fix camera image #52738

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Esphome fix camera image #52738

merged 2 commits into from
Jul 8, 2021

Conversation

jesserockz
Copy link
Member

@jesserockz jesserockz commented Jul 8, 2021

Breaking change

Proposed change

Fixes a bug introduced in esphome/aioesphomeapi#36
aioesphomeapi version release: https://github.com/esphome/aioesphomeapi/releases/tag/v5.0.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @OttoWinter, mind taking a look at this pull request as its been labeled with an integration (esphome) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added this to the 2021.7.1 milestone Jul 8, 2021
Copy link
Member

@OttoWinter OttoWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed that. Thanks!

@frenck
Copy link
Member

frenck commented Jul 8, 2021

@OttoWinter, 4.1.0 adds a whole bunch of other things, like new re-connect logic, which has not been merged/published before. This broadens the scope of this PR.

Does that effect / potentially have other consequences?

@OttoWinter
Copy link
Member

like new re-connect logic,

Yes, that is added. But it's only an "additive" change (so a new module). It shouldn't affect existing uses of the library much (ok a bit of logging was cleaned up too, but I tested that well).

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clearing that up @OttoWinter 👍

Thanks for fixing @jesserockz 🥇

@frenck frenck merged commit 94e15b3 into dev Jul 8, 2021
@frenck frenck deleted the esphome/fix-camera-image branch July 8, 2021 12:44
tkdrob pushed a commit to tkdrob/core that referenced this pull request Jul 8, 2021
frenck pushed a commit that referenced this pull request Jul 8, 2021
@frenck frenck mentioned this pull request Jul 8, 2021
@jlt24
Copy link

jlt24 commented Jul 8, 2021

I still have the same issue after updating to 2021.7.1

@frenck
Copy link
Member

frenck commented Jul 8, 2021

@jlt24 This is a pull request, please raise an issue if you are experiencing one. Thanks! 👍

sjiampojamarn pushed a commit to sjiampojamarn/core that referenced this pull request Jul 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 camera not working after update to 2021.7.0
5 participants