-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Esphome fix camera image #52738
Esphome fix camera image #52738
Conversation
Hey there @OttoWinter, mind taking a look at this pull request as its been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, missed that. Thanks!
@OttoWinter, 4.1.0 adds a whole bunch of other things, like new re-connect logic, which has not been merged/published before. This broadens the scope of this PR. Does that effect / potentially have other consequences? |
Yes, that is added. But it's only an "additive" change (so a new module). It shouldn't affect existing uses of the library much (ok a bit of logging was cleaned up too, but I tested that well). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clearing that up @OttoWinter 👍
Thanks for fixing @jesserockz 🥇
I still have the same issue after updating to 2021.7.1 |
@jlt24 This is a pull request, please raise an issue if you are experiencing one. Thanks! 👍 |
Breaking change
Proposed change
Fixes a bug introduced in esphome/aioesphomeapi#36
aioesphomeapi version release: https://github.com/esphome/aioesphomeapi/releases/tag/v5.0.0
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: