Switch from attrs to dataclasses #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
jesserockz
reviewed
Jul 8, 2021
| @@ -284,7 +256,7 @@ def on_msg(msg: message.Message) -> None: | |||
| if isinstance(msg, CameraImageResponse): | |||
| data = image_stream.pop(msg.key, bytes()) + msg.data | |||
| if msg.done: | |||
| on_state(CameraState(key=msg.key, image=data)) | |||
There was a problem hiding this comment.
The issue people are experiencing on HA 2021.7 is because the new from_pb function only matches the attributes in the dataclass by exact name. That is image in CameraState but in CameraImageResponse it is data. Simple fix is to rename the attr to data and the references inside HA
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python attrs was used in the time when we still had to work with python 3.5
In Python 3.7+, we have python's stdlib dataclasses.
They're mostly the same (but
dataclasslacksconverterfunctionality, which is manually added with a metaclass), but using the stdlib feels cleaner.Note: this is a pretty big API breaking change, so would need major version bump, and some changes in HA.