-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from attrs to dataclasses #36
Merged
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
644a904
Switch from attrs to dataclasses
OttoWinter 7b2b4b9
Fix int enum
OttoWinter b35bc94
Min python 3.7
OttoWinter 5ff36e1
Also convert ConnectionParams
OttoWinter 63d4618
Merge remote-tracking branch 'origin/master' into use-dataclasses
OttoWinter c81f67a
Fixes after merge
OttoWinter 4992208
Fix bad merge
OttoWinter 5c4ad84
Lint
OttoWinter a85a765
Fixes
OttoWinter a8f1763
Merge remote-tracking branch 'origin/master' into use-dataclasses
OttoWinter f34e532
Lint
OttoWinter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge remote-tracking branch 'origin/master' into use-dataclasses
- Loading branch information
commit a8f1763dd2b1572118397caa7101119117e260b7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue people are experiencing on HA 2021.7 is because the new
from_pb
function only matches the attributes in the dataclass by exact name. That isimage
inCameraState
but inCameraImageResponse
it isdata
. Simple fix is to rename the attr to data and the references inside HA