Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ESPHome Camera not merging image packets #52783

Merged
merged 1 commit into from
Jul 9, 2021

Conversation

OttoWinter
Copy link
Member

Proposed change

Fix another issue with ESPHome Cameras - this time tested with an ESP32 camera

Release: https://github.com/esphome/aioesphomeapi/releases/tag/v5.0.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @jesserockz, mind taking a look at this pull request as its been labeled with an integration (esphome) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@jesserockz jesserockz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see what you have done there... Yeah makes sense.

@OttoWinter
Copy link
Member Author

I guess it's time for me to introduce some automated unit testing in aioesphomeapi 😅

@djdobs
Copy link

djdobs commented Jul 9, 2021

I appreciate everything you guys do, I'm genuinely impressed by your talent and skills so I hope this doesn't sound rude or impatient.... but when can we expect this update/fix to become available? Or is there any work-around until then? Again I am honestly very grateful for what you code gods create and maintain. I'm just keen to get the esp32 cameras working again! Thanks peeps :)

@OttoWinter OttoWinter deleted the fix-esphome-camera branch July 9, 2021 19:51
@OttoWinter
Copy link
Member Author

When 2021.7.2 is released - depends on when the HA maintainers have time.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32Cam integrated through esphome not displaying in Lovelace
6 participants