-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ESPHome Camera not merging image packets #52783
Conversation
Hey there @jesserockz, mind taking a look at this pull request as its been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see what you have done there... Yeah makes sense.
I guess it's time for me to introduce some automated unit testing in aioesphomeapi 😅 |
I appreciate everything you guys do, I'm genuinely impressed by your talent and skills so I hope this doesn't sound rude or impatient.... but when can we expect this update/fix to become available? Or is there any work-around until then? Again I am honestly very grateful for what you code gods create and maintain. I'm just keen to get the esp32 cameras working again! Thanks peeps :) |
When 2021.7.2 is released - depends on when the HA maintainers have time. |
Proposed change
Fix another issue with ESPHome Cameras - this time tested with an ESP32 camera
Release: https://github.com/esphome/aioesphomeapi/releases/tag/v5.0.1
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: