Skip to content

Downgrade aiohttp to 3.8.5#101913

Merged
frenck merged 1 commit intorcfrom
frenck-2023-1257
Oct 13, 2023
Merged

Downgrade aiohttp to 3.8.5#101913
frenck merged 1 commit intorcfrom
frenck-2023-1257

Conversation

@frenck
Copy link
Member

@frenck frenck commented Oct 12, 2023

Proposed change

Reverts #101590 against our rc: Downgrade aiohttp back to 3.8.5
We can't do this via dev, as dev is currently on aiohttp 3.9.0b0.

The issue: Ingress not always working. However, when the cache in the browser is disabled, it does work.

CleanShot.2023-10-13.at.00.18.30-converted.mp4

☝️ Please note how ingress works with the dev tools (and cache disabled) open, but doesn't when dev tools are closed.

Confirmed on nightly by installing 3.8.5, which makes the issue go away. Also confirmed by @joostlek who could reproduce on 2023.10.2, and downgrading also solved it on his end.

As for nightly, it has the same issue. I keep nightly in a "broken" state right now (workaround disable cache). As it gives us a platform to debug this more.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck added this to the 2023.10.3 milestone Oct 12, 2023
@home-assistant home-assistant bot added bugfix cla-signed core Hacktoberfest merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines. labels Oct 12, 2023
@briangunderson
Copy link

My environment is affected by this as well. Happy to help supply logs/etc if it will be useful. Lmk!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix cherry-picked cla-signed core Hacktoberfest merging-to-rc This PR is merging into the RC branch and should probably change the branch to `dev`. small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants