Conversation
mdegat01
approved these changes
Oct 12, 2023
|
My environment is affected by this as well. Happy to help supply logs/etc if it will be useful. Lmk! |
This was referenced Oct 13, 2023
8 tasks
Merged
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Reverts #101590 against our
rc: Downgradeaiohttpback to 3.8.5We can't do this via
dev, asdevis currently onaiohttp3.9.0b0.The issue: Ingress not always working. However, when the cache in the browser is disabled, it does work.
CleanShot.2023-10-13.at.00.18.30-converted.mp4
☝️ Please note how ingress works with the dev tools (and cache disabled) open, but doesn't when dev tools are closed.
Confirmed on nightly by installing 3.8.5, which makes the issue go away. Also confirmed by @joostlek who could reproduce on 2023.10.2, and downgrading also solved it on his end.
As for nightly, it has the same issue. I keep nightly in a "broken" state right now (workaround disable cache). As it gives us a platform to debug this more.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: