Skip to content

Add test to confirm regression of parsing chunked with no length (3.8.6/3.9.0b)#7697

Closed
bdraco wants to merge 3 commits intoaio-libs:masterfrom
bdraco:parse_zero_chunked
Closed

Add test to confirm regression of parsing chunked with no length (3.8.6/3.9.0b)#7697
bdraco wants to merge 3 commits intoaio-libs:masterfrom
bdraco:parse_zero_chunked

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Oct 13, 2023

What do these changes do?

This is to confirm the related issue home-assistant/core#101893 (and home-assistant/core#101913)

This regression affects 3.8.6 and 3.9.0b

I haven't figure out the source yet. It appears to be limited to the c parser.

This is a regression in llhttp. I don't have a solution, but I do have a test case: nodejs/llhttp#256

The failure is here: https://github.com/aio-libs/aiohttp/actions/runs/6502938416/job/17662729062?pr=7697

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@bdraco bdraco changed the title Add test for parsing chunked with no length Add test to confirm regression of parsing chunked with no length Oct 13, 2023
@bdraco bdraco changed the title Add test to confirm regression of parsing chunked with no length Add test to confirm regression of parsing chunked with no length (3.8.6/3.9.0b) Oct 13, 2023
@frenck
Copy link

frenck commented Oct 13, 2023

Affects #7675

@frenck frenck mentioned this pull request Oct 13, 2023
8 tasks
@Dreamsorcerer
Copy link
Member

Looks like this one is redundant now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants