fix-aiohttp-requirement

[EdLeckert]

To fix hass-opensprinkler OpenSprinkler not working since update to HA2023.10.2 #259

[vinteo]

I am a bit conflicted about >= but maybe we should just do it. Can you resolve the conflict and I will merge it

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (78514dd) 69.42% compared to head (2e70c4a) 69.42%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master      #84   +/-   ##
=======================================
  Coverage   69.42%   69.42%           
=======================================
  Files           4        4           
  Lines         870      870           
=======================================
  Hits          604      604           
  Misses        266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[EdLeckert]

I hear ya', but I can't see how letting it break with every other release of HA helps anyone.

Let me look into how one does that.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[EdLeckert]

Obviously I hadn't noticed that you had already made the change. Sorry about that.

[EdLeckert]

@vinteo Have you seen this?:

Release 2023.10.3 - October 13

• Downgrade aiohttp to 3.8.5 (@frenck - #101913)

[vinteo]

No... Well people can downgrade the integration too lol. I don't get the dependency management system here coming from node.js

…

On Sat, Oct 14, 2023, 5:29 AM Ed Leckert ***@***.***> wrote: @vinteo <https://github.com/vinteo> Have you seen this?: Release 2023.10.3 - October 13 - Downgrade aiohttp to 3.8.5 ***@***.*** <https://github.com/frenck> - #101913 <home-assistant/core#101913>) — Reply to this email directly, view it on GitHub <#84 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGID7ZDZDFYYSOQQCMDAGDX7GB7TANCNFSM6AAAAAA56HXQRI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[vinteo]

Should we do a release as well? We have the >= now and can go with 3.8.5

…

On Sat, Oct 14, 2023, 7:48 AM Vincent Teo ***@***.***> wrote: No... Well people can downgrade the integration too lol. I don't get the dependency management system here coming from node.js On Sat, Oct 14, 2023, 5:29 AM Ed Leckert ***@***.***> wrote: > @vinteo <https://github.com/vinteo> Have you seen this?: > Release 2023.10.3 - October 13 > > - Downgrade aiohttp to 3.8.5 ***@***.*** <https://github.com/frenck> - > #101913 <home-assistant/core#101913>) > > — > Reply to this email directly, view it on GitHub > <#84 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAGID7ZDZDFYYSOQQCMDAGDX7GB7TANCNFSM6AAAAAA56HXQRI> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> >

[EdLeckert]

I think we're fine as is. I was just pointing out what could have happened with the back and forth in HA.