WIP fix: do not encode IDN domain #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
curbengh
commented
Aug 18, 2019
| @@ -67,4 +68,20 @@ describe('Sitemap generator', () => { | |||
| result.should.be.ok; | |||
| }); | |||
| }); | |||
|
|
|||
| it('IDN handling', () => { | |||
| hexo.config.url = 'http://fôo.com/bár'; | |||
There was a problem hiding this comment.
While this option can be applied, but the following result still show "http://yoursite.com/".
This PR does work in a test blog, but somehow not in a unit test.
There was a problem hiding this comment.
I think it's related to describe() it(). But I don't know how to proceed.
There was a problem hiding this comment.
could also related to how urlObject is referenced/dereferenced.
2 tasks
|
Pending hexojs/hexo-util#77 |
curbengh
changed the title
|
hexojs/hexo-util#77 merged |
This was referenced Sep 8, 2019
|
Superseded by #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More comprehensive approach to #61. This PR also encode root value.