-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP fix: do not encode IDN domain #66
Conversation
@@ -67,4 +68,20 @@ describe('Sitemap generator', () => { | |||
result.should.be.ok; | |||
}); | |||
}); | |||
|
|||
it('IDN handling', () => { | |||
hexo.config.url = 'http://fôo.com/bár'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this option can be applied, but the following result
still show "http://yoursite.com/".
This PR does work in a test blog, but somehow not in a unit test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's related to describe()
it()
. But I don't know how to proceed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could also related to how urlObject is referenced/dereferenced.
Pending hexojs/hexo-util#77 |
hexojs/hexo-util#77 merged |
Superseded by #68 |
More comprehensive approach to #61. This PR also encode root value.