fix(idn): encode url except domain #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
commented
Sep 8, 2019
|
Your title is wrong. Idn should not be encoded to punycode. Ever. Just the path should be encoded. |
curbengh
changed the title
curbengh
force-pushed
the
idn-handling
branch
from
0ee9d1e
to
1313ba4
Compare
Updated title and commit message. I think you might have confused percent-encoding with punycode. IDN must not be encoded to percent-encoding, but it can be encoded to punycode even though it's not required. btw, don't merge this until we can figure out the failing test. |
curbengh
changed the title
This was referenced Sep 9, 2019
curbengh
changed the title
|
Pending hexojs/hexo#3708 |
curbengh
force-pushed
the
idn-handling
branch
from
1313ba4
to
0a3d41d
Compare
curbengh
changed the title
|
Fixed failing test. Ready to be reviewed. |
curbengh
force-pushed
the
idn-handling
branch
from
0a3d41d
to
97b99be
Compare
curbengh
force-pushed
the
idn-handling
branch
from
97b99be
to
66c708f
Compare
|
@hexojs/core |
SukkaW
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compatibility with hexo v4 (hexojs/hexo#3708), while maintaining backward compatibility with v3, #74 is not compatible with v3 nor IDN.
Fixes hexojs/hexo-generator-feed#63
Supersede #66, #74