fix(IDN): uriencode root value #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
curbengh
changed the title
|
Pending hexojs/hexo#3708 Edit: hexojs/hexo#3708 is compatible with encodeURL(), regardless whether the url/path is already encoded or not. |
curbengh
changed the title
|
Rebased |
curbengh
requested review from
tomap and
a team
and removed request for
a team and
tomap
SukkaW
approved these changes
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current approach does not encode the root value, this PR fixes that.
Similar to hexojs/hexo-generator-sitemap#66
This PR is necessary to be compatible with hexo v4 and v3 or older (forward & backward compatibility).
Supersede #88