Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/zookeeper] Update api versions to support k8s 1.16 #18049

Merged
merged 3 commits into from
Oct 21, 2019
Merged

[stable/zookeeper] Update api versions to support k8s 1.16 #18049

merged 3 commits into from
Oct 21, 2019

Conversation

antongorkovenko
Copy link
Contributor

Signed-off-by: Anton Gorkovenko gostom@gmail.com

Is this a new chart

no

What this PR does / why we need it:

Update api versions to support k8s 1.16

Which issue this PR fixes

no

Special notes for your reviewer:

no

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

@antongorkovenko
Update api versions to support k8s 1.16
6919907 
Signed-off-by: Anton Gorkovenko <gostom@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @antongorkovenko. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@antongorkovenko
Copy link
Contributor Author

/assign @lachie83

@antongorkovenko
Update api versions to support k8s 1.16
9192e79 
Signed-off-by: Anton Gorkovenko <gostom@gmail.com>
@zanhsieh
Copy link
Collaborator

@antongorkovenko
Need to resolve conflict on incubator/zookeeper/Chart.yaml

@antongorkovenko
Copy link
Contributor Author

@zanhsieh resolved

@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2019
Aisuko
Aisuko suggested changes Oct 21, 2019
View reviewed changes
Copy link
Collaborator

@Aisuko Aisuko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, There are some questions and expect your reply.

incubator/zookeeper/templates/statefulset.yaml
@@ -1,4 +1,4 @@
apiVersion: apps/v1beta1
apiVersion: apps/v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but could you please explain why change v1beta1 to v1?

Copy link
Contributor Author

@antongorkovenko antongorkovenko Oct 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1beta has been removed in 1.16: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

incubator/zookeeper/README.md
@@ -3,7 +3,7 @@
This helm chart provides an implementation of the ZooKeeper [StatefulSet](http://kubernetes.io/docs/concepts/abstractions/controllers/statefulsets/) found in Kubernetes Contrib [Zookeeper StatefulSet](https://github.com/kubernetes/contrib/tree/master/statefulsets/zookeeper).

## Prerequisites
* Kubernetes 1.6+
* Kubernetes 1.10+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, What's the mean of this? Statefulset API version is not backward compatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, new API version is not available in 1.6

@lachie83
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: antongorkovenko, lachie83

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2215d0f into helm:master Oct 21, 2019
@Aisuko
Copy link
Collaborator

Aisuko commented Oct 22, 2019

Thanks

demisx added a commit to beocommedia/charts that referenced this pull request Oct 22, 2019
@demisx
Merge branch 'update-chart-version'
af61f15 
* update-chart-version: (983 commits)
  [stable/stolon] Add OWNERS file
  Upgrade Stolon image to v0.13.0-pg11
  [stable/sonatype-nexus] adding ACM cert annotations and LoadBalancer source IP whitelisting support (helm#16577)
  [stable/redis] Add loadBalancerSourceRanges to redis master and slave (helm#18064)
  Allow to configure kube-proxy endpoints (helm#17918)
  bump chart and vault versions (helm#18133)
  [stable/goldpinger] add ServiceMonitor (helm#18142)
  [stable/karma] Add configuration for service labels (helm#18169)
  Chore: Update github template to be more specific about naming convention. (helm#18074)
  Following improvements has been ported the charts: (helm#18035)
  fix: disable httpsPort by default (helm#18113)
  [stable/parse] fix README typo and bumped chart version (helm#18086)
  Add value to enable probes (helm#18160)
  helm#17684 add extraEnv vars (helm#17963)
  Add protocol configuration for nginx-ldap-proxy (helm#15532)
  [stable/consul] Fixes compatibility with 1.16 (helm#17527)
  [stable/Locust] adding a new maintainer (helm#17719)
  [stable/zookeeper] Update api versions to support k8s 1.16 (helm#18049)
  [stable/azuremonitor-containers] Update api versions to support k8s 1.16 (helm#18046)
  [stable/distributed-tensorflow] Add custom variable to set number of training steps. (helm#16436)
  ...
reloaded pushed a commit to reloaded/charts that referenced this pull request Oct 22, 2019
@antongorkovenko @reloaded
[stable/zookeeper] Update api versions to support k8s 1.16 (helm#18049)
5d25451 
* Update api versions to support k8s 1.16

Signed-off-by: Anton Gorkovenko <gostom@gmail.com>

* Update api versions to support k8s 1.16

Signed-off-by: Anton Gorkovenko <gostom@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Aisuko Aisuko Aisuko requested changes

@kow3ns kow3ns Awaiting requested review from kow3ns

@lachie83 lachie83 Awaiting requested review from lachie83

Assignees

@lachie83 lachie83

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@antongorkovenko @k8s-ci-robot @zanhsieh @lachie83 @Aisuko @helm-bot