This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Update github template to be more specific about naming convention. #18074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/M
…tion. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
helm-bot
added
Contribution Allowed
|
/assign prydonius |
Miouge1
approved these changes
Oct 17, 2019
There was a problem hiding this comment.
Not sure why @k8s-ci-robot assigned me as reviewer here, but looks good to me.
/lgtm
|
@Miouge1: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desaintmartin, maorfr, Miouge1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
demisx
added a commit
to beocommedia/charts
that referenced
this pull request
Oct 22, 2019
* update-chart-version: (983 commits) [stable/stolon] Add OWNERS file Upgrade Stolon image to v0.13.0-pg11 [stable/sonatype-nexus] adding ACM cert annotations and LoadBalancer source IP whitelisting support (helm#16577) [stable/redis] Add loadBalancerSourceRanges to redis master and slave (helm#18064) Allow to configure kube-proxy endpoints (helm#17918) bump chart and vault versions (helm#18133) [stable/goldpinger] add ServiceMonitor (helm#18142) [stable/karma] Add configuration for service labels (helm#18169) Chore: Update github template to be more specific about naming convention. (helm#18074) Following improvements has been ported the charts: (helm#18035) fix: disable httpsPort by default (helm#18113) [stable/parse] fix README typo and bumped chart version (helm#18086) Add value to enable probes (helm#18160) helm#17684 add extraEnv vars (helm#17963) Add protocol configuration for nginx-ldap-proxy (helm#15532) [stable/consul] Fixes compatibility with 1.16 (helm#17527) [stable/Locust] adding a new maintainer (helm#17719) [stable/zookeeper] Update api versions to support k8s 1.16 (helm#18049) [stable/azuremonitor-containers] Update api versions to support k8s 1.16 (helm#18046) [stable/distributed-tensorflow] Add custom variable to set number of training steps. (helm#16436) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lot of PRs have literaly "[stable/charts]" in their name.