Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/zookeeper] Update api versions to support k8s 1.16 #18049

Merged
merged 3 commits into from
Oct 21, 2019
Merged

[stable/zookeeper] Update api versions to support k8s 1.16 #18049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6919907
Update api versions to support k8s 1.16
antongorkovenko Oct 16, 2019
9192e79
Update api versions to support k8s 1.16
antongorkovenko Oct 16, 2019
9a45582
Merge branch 'master' into zoo
antongorkovenko Oct 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion incubator/zookeeper/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
apiVersion: v1
name: zookeeper
home: https://zookeeper.apache.org/
version: 2.0.2
version: 2.1.0
appVersion: 3.5.5
kubeVersion: "^1.10.0-0"
description: Centralized service for maintaining configuration information, naming,
providing distributed synchronization, and providing group services.
icon: https://zookeeper.apache.org/images/zookeeper_small.gif
Expand Down
2 changes: 1 addition & 1 deletion incubator/zookeeper/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
This helm chart provides an implementation of the ZooKeeper [StatefulSet](http://kubernetes.io/docs/concepts/abstractions/controllers/statefulsets/) found in Kubernetes Contrib [Zookeeper StatefulSet](https://github.com/kubernetes/contrib/tree/master/statefulsets/zookeeper).

## Prerequisites
* Kubernetes 1.6+
* Kubernetes 1.10+
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, What's the mean of this? Statefulset API version is not backward compatible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, new API version is not available in 1.6

* PersistentVolume support on the underlying infrastructure
* A dynamic provisioner for the PersistentVolumes
* A familiarity with [Apache ZooKeeper 3.5.x](https://zookeeper.apache.org/doc/r3.5.5/)
Expand Down
2 changes: 1 addition & 1 deletion incubator/zookeeper/templates/statefulset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: apps/v1beta1
apiVersion: apps/v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry, but could you please explain why change v1beta1 to v1?

Copy link
Contributor Author

@antongorkovenko antongorkovenko Oct 21, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v1beta has been removed in 1.16: https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/

kind: StatefulSet
metadata:
name: {{ template "zookeeper.fullname" . }}
Expand Down