Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deer: implement Deserialize for core::cell #2376

Merged
merged 8 commits into from
Apr 13, 2023
Merged

deer: implement Deserialize for core::cell #2376

merged 8 commits into from
Apr 13, 2023

Conversation

indietyp
Copy link
Member

@indietyp indietyp commented Apr 8, 2023

🌟 What is the purpose of this PR?

This is an "explosion" of #1875 and implements Deserialize for:

  • core::cell::Cell
  • core::cell::RefCell
  • core::cell::UnsafeCell
  • core::cell::OnceCell
  • core::cell::SyncUnsafeCell

🔗 Related links

🔍 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)
  • modifies a Cargo-publishable library and I have amended the version
  • modifies a Cargo-publishable library, but it is not yet ready to publish
  • modifies a block that will need publishing via GitHub action once merged
  • does not modify any publishable blocks or libraries
  • I am unsure / need advice

@indietyp indietyp requested a review from a team as a code owner April 8, 2023 19:49
@github-actions github-actions bot added the area/libs > deer Affects the `deer` crate (library) label Apr 8, 2023
@codecov
Copy link

codecov bot commented Apr 8, 2023

Codecov Report

Merging #2376 (09103a4) into main (7633fdd) will increase coverage by 0.02%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
+ Coverage   60.69%   60.72%   +0.02%     
==========================================
  Files         317      317              
  Lines       24279    24275       -4     
  Branches      421      421              
==========================================
+ Hits        14737    14741       +4     
+ Misses       9537     9529       -8     
  Partials        5        5              
Flag Coverage Δ
backend-integration-tests 3.66% <ø> (ø)
deer 69.36% <89.65%> (+0.12%) ⬆️
unit-tests 1.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/deer/desert/src/lib.rs 100.00% <ø> (ø)
libs/deer/src/lib.rs 73.80% <ø> (ø)
libs/deer/src/impls/core/cell.rs 62.50% <62.50%> (ø)
libs/deer/desert/src/assert.rs 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

TimDiekmann
TimDiekmann previously approved these changes Apr 12, 2023
@indietyp indietyp added this pull request to the merge queue Apr 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Apr 13, 2023
@indietyp indietyp deleted the bm/deer/core-cell branch April 13, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > deer Affects the `deer` crate (library)
Development

Successfully merging this pull request may close these issues.

2 participants