Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deer implement Deserialize for built-in types (Part 2) #1875

Closed
wants to merge 29 commits into from

Conversation

indietyp
Copy link
Member

@indietyp indietyp commented Jan 18, 2023

🌟 What is the purpose of this PR?

Implements the remaining types from core (except if PR gets too big).

🔗 Related links

🚫 Blocked by

🔍 What does this change?

Implementation of the standard library

🐾 Next steps

implement alloc

🛡 What tests cover this?

unit and integration tests that will be present

📹 Demo

@indietyp indietyp changed the title deer implement Deserialize for built-in types (Part 2) deer implement Deserialize for built-in types (Part 2) Jan 18, 2023
@github-actions github-actions bot added the area/libs > deer Affects the `deer` crate (library) label Jan 18, 2023
@indietyp indietyp marked this pull request as draft January 18, 2023 15:18
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1875 (937f8d5) into main (57d3933) will decrease coverage by 3.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1875      +/-   ##
==========================================
- Coverage   61.05%   57.08%   -3.98%     
==========================================
  Files         296      286      -10     
  Lines       22964    19826    -3138     
  Branches      420      420              
==========================================
- Hits        14020    11317    -2703     
+ Misses       8939     8504     -435     
  Partials        5        5              
Flag Coverage Δ
backend-integration-tests 3.66% <ø> (ø)
sarif ?
unit-tests 1.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libs/deer/src/error.rs 52.00% <ø> (ø)
libs/deer/src/lib.rs 75.56% <ø> (ø)
libs/deer/src/value/array.rs 0.00% <ø> (ø)
libs/deer/src/value/object.rs 0.00% <ø> (ø)

... and 64 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vercel
Copy link

vercel bot commented Jan 25, 2023

Deployment failed with the following error:

Was unable to schedule a deployment.

@vercel
Copy link

vercel bot commented Jan 25, 2023

Deployment failed with the following error:

Creating the Deployment Timed Out.

indietyp added a commit that referenced this pull request Apr 9, 2023
indietyp added a commit that referenced this pull request Apr 10, 2023
indietyp added a commit that referenced this pull request Apr 10, 2023
indietyp added a commit that referenced this pull request Apr 10, 2023
indietyp added a commit that referenced this pull request Apr 10, 2023
indietyp added a commit that referenced this pull request Apr 10, 2023
indietyp added a commit that referenced this pull request Apr 10, 2023
indietyp added a commit that referenced this pull request Apr 13, 2023
* chore: move from #1875

* feat: impl `Ordering`

* test: `core::cmp`

* test: reflection same for `Reverse`

* fix: miri
indietyp added a commit that referenced this pull request Apr 13, 2023
* feat: move from #1875

* test: `ManuallyDrop`

* fix: `Reflection`

* chore: remove unused imports

* fix: miri
indietyp added a commit that referenced this pull request Apr 13, 2023
* chore: import from #1875

* chore: docs

* test: `Option`
indietyp added a commit that referenced this pull request Apr 13, 2023
* chore: convert from #1875

* test: `PhantomData`
indietyp added a commit that referenced this pull request Apr 13, 2023
* feat: init cell

* feat: pull in code from #1875

* feat: test cells

* test: unsafe variants

* test: reflection passthrough

* fix: lint

* Update test_impls_core_cell.rs
indietyp added a commit that referenced this pull request Apr 13, 2023
* feat: init cell

* feat: pull in code from #1875

* feat: test cells

* test: unsafe variants

* test: reflection passthrough

* fix: lint

* Update test_impls_core_cell.rs

* feat: move atomic to correct sub-folder

* feat: import #1875

* test: `Exclusive`

* fix: test

* chore: lint

* chore: lint
indietyp added a commit that referenced this pull request Apr 13, 2023
indietyp added a commit that referenced this pull request Apr 14, 2023
* feat: import from #1875

* test: byte-string
indietyp added a commit that referenced this pull request Apr 14, 2023
* feat: init cell

* feat: pull in code from #1875

* feat: test cells

* test: unsafe variants

* test: reflection passthrough

* fix: lint

* Update test_impls_core_cell.rs

* chore: convert from #1875

* test: duration deserialization

* test: time via approx

* fix: miri

* feat: implement relative assert ourselves

* chore: grammar c:
@indietyp
Copy link
Member Author

closing in favor of several PRs that split up this PR, not converting to a smaller PR due to the fact that all of them refer back to this one as the "originator".

@indietyp indietyp closed this Apr 14, 2023
indietyp added a commit that referenced this pull request Apr 28, 2023
* feat: glue helper trait `TupleExt`

* feat: take code from #1875 and fix

* test: array impl

* fix: miri
CiaranMn pushed a commit that referenced this pull request Apr 28, 2023
* feat: glue helper trait `TupleExt`

* feat: take code from #1875 and fix

* test: array impl

* fix: miri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libs > deer Affects the `deer` crate (library)
Development

Successfully merging this pull request may close these issues.

1 participant