Backport of Bump go-getter v1.8.2 into v1.13 #37836
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #37752 to be assessed for backporting due to the inclusion of the label 1.13-backport.
🚨
The person who merged in the original PR is:
@YakDriver
This person should resolve the merge-conflict(s) by either:
The below text is copied from the body of the original PR.
tl;dr: We want AWS non-standard partition support plus security improvements without impacting Windows support.
The main point was for Terraform via go-getter to support work in AWS partitions besides
aws, such as GovCloud, China, isolated, and custom partitions. That was achieved in go-getter v1.8.0, which also modernized code and moved off unsupported aws-sdk-go v1.However, go-getter v1.8.0, via modern Go (1.23+), also introduced problems with Windows junction points. To fix this, go-getter v1.8.1 added comprehensive symlink resolution with Windows junction point support. Now, v1.8.2 fixes an issue on Windows with temporary directories.
Related:
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry
Overview of commits