Bump go-getter v1.8.2 #37752
Merged
Bump go-getter v1.8.2 #37752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YakDriver
added
no-changelog-needed
YakDriver
force-pushed
the
t-bump-go-getter
branch
from
59c24a7 to
edb3f64
Compare
jar-b
approved these changes
Oct 10, 2025
Member
jar-b
left a comment
jar-b
left a comment
There was a problem hiding this comment.
LGTM 🎉
% TF_ACC=1 go test -count=1 ./...
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 216.237s
3 tasks
SarahFrench
added
the
1.13-backport
Contributor
Backported dependency changeThis PR makes changes to dependencies in go.mod file(s) and is labelled for backport. Notice to the maintainer: Before merging the backport of this PR please follow our security scanning processes. |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr: We want AWS non-standard partition support plus security improvements without impacting Windows support.
The main point was for Terraform via go-getter to support work in AWS partitions besides
aws, such as GovCloud, China, isolated, and custom partitions. That was achieved in go-getter v1.8.0, which also modernized code and moved off unsupported aws-sdk-go v1.However, go-getter v1.8.0, via modern Go (1.23+), also introduced problems with Windows junction points. To fix this, go-getter v1.8.1 added comprehensive symlink resolution with Windows junction point support. Now, v1.8.2 fixes an issue on Windows with temporary directories.
Related:
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry