-
Notifications
You must be signed in to change notification settings - Fork 10.1k
bump: go-getter to 1.8.0 #37567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: go-getter to 1.8.0 #37567
Conversation
jar-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting a persistent failure in this S3 backend acceptance test with this change.
% TF_ACC=1 go test -count=1 ./... -run=TestRemoteClient_stateChecksum
--- FAIL: TestRemoteClient_stateChecksum (11.53s)
client_test.go:314: TestBackendConfig on *s3.Backend with configtesting.synthBody{Filename:"<TestWrapConfig>", Values:map[string]cty.Value{"bucket":cty.StringVal("terraform-remote-s3-test-68bedf58"), "dynamodb_table":cty.StringVal("terraform-remote-s3-test-68bedf58"), "key":cty.StringVal("testState")}}
client_test.go:320: creating S3 bucket terraform-remote-s3-test-68bedf58 in us-east-1
backend_test.go:3649: creating DynamoDB table terraform-remote-s3-test-68bedf58
client_test.go:346: TestBackendConfig on *s3.Backend with configtesting.synthBody{Filename:"<TestWrapConfig>", Values:map[string]cty.Value{"bucket":cty.StringVal("terraform-remote-s3-test-68bedf58"), "key":cty.StringVal("testState")}}
client_test.go:389: expected state checksum error: got state data in S3 does not have the expected content.
The checksum calculated for the state stored in S3 does not match the checksum
stored in DynamoDB.
Bucket: terraform-remote-s3-test-68bedf58
Key: testState
Calculated checksum:
Stored checksum: bf36014ebaea5474d1278bbafb66a2c5
This may be caused by unusually long delays in S3 processing a previous state
update. Please wait for a minute or two and try again.
If this problem persists, and neither S3 nor DynamoDB are experiencing an
outage, you may need to manually verify the remote state and remove the Digest
value stored in the DynamoDB table
FAIL
FAIL github.com/hashicorp/terraform/internal/backend/remote-state/s3 11.992s
FAIL|
Correction - this is also failing on |
|
Impacted test has been fixed via #37571. All other S3 backend tests were passing on this branch as-is. |
|
Sweet! Thanks @jar-b @SarahFrench @jbardin |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
See hashicorp/go-getter#548 and hashicorp/go-getter#549
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry