Skip to content

Actions plumbing #43669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Sep 17, 2025
Merged

Actions plumbing #43669

merged 22 commits into from
Sep 17, 2025

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Aug 1, 2025 •
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

This PR provides the plumbing necessary to make Terraform Actions work in the Terraform AWS Provider.

Relations

To do:

Relations:

References

Output from Acceptance Testing

N/A - Cover by `go test` and dependents

@YakDriver YakDriver requested a review from a team as a code owner August 1, 2025 21:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. provider Pertains to the provider itself, rather than any interaction with AWS. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 1, 2025
@YakDriver YakDriver force-pushed the f-ec2-instance-action branch from 9b49a4c to e99ec05 Compare August 1, 2025 21:42
@YakDriver YakDriver marked this pull request as draft August 1, 2025 23:03
@YakDriver YakDriver mentioned this pull request Aug 6, 2025
Merged
14 tasks
@YakDriver YakDriver force-pushed the f-ec2-instance-action branch from 78c2efb to 7db6bf8 Compare August 18, 2025 21:36
This was referenced Aug 19, 2025
Merged
Merged
This was referenced Sep 10, 2025
Merged
Merged
jar-b
jar-b reviewed Sep 16, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

internal/generate/servicepackage/main.go Outdated
Comment on lines 546 to 548
if d.HasV6_0SDKv2Fix {
v.errs = append(v.errs, fmt.Errorf("V60SDKv2Fix not supported for Actions: %s", fmt.Sprintf("%s.%s", v.packageName, v.functionName)))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we check and error only on this annotation? It seems there could be many which don't apply to actions (SingletonIdentity, WrappedImport, etc.).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right. The V60SDKv2Fix annotation was specifically created to address a v6.0 provider bug related to the Resource Identity feature that only affected certain SDK-based resources. Since Actions are a new resource type that wasn't affected by that bug, this check is unnecessary.

Looking at the broader pattern, if we want to validate unsupported annotations for Actions, we should either:

  • Validate ALL annotations that don't apply to Actions (not just V60SDKv2Fix), or
  • Remove this specific check since it's not needed

I'll remove the V60SDKv2Fix check for Actions since it's not applicable.

@YakDriver YakDriver requested a review from jar-b September 16, 2025 22:31
@github-actions github-actions bot added the linter Pertains to changes to or issues with the various linters. label Sep 17, 2025
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. service/elasticache Issues and PRs that pertain to the elasticache service. service/workspaces Issues and PRs that pertain to the workspaces service. service/securityhub Issues and PRs that pertain to the securityhub service. service/memorydb Issues and PRs that pertain to the memorydb service. service/ce Issues and PRs that pertain to the ce service. labels Sep 17, 2025
@github-actions github-actions bot added the service/iam Issues and PRs that pertain to the iam service. label Sep 17, 2025
This was referenced Sep 17, 2025
Merged
Merged
@YakDriver YakDriver marked this pull request as ready for review September 17, 2025 13:48
@YakDriver
Copy link
Member Author

YakDriver commented Sep 17, 2025 •
edited
Loading

FYI, rebase on this one #43669:

% make t T=TestAccLambdaInvokeAction_ K=lambda     
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-lambda-invoke-action 🌿...
TF_ACC=1 go1.24.6 test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaInvokeAction_'  -timeout 360m -vet=off
2025/09/17 09:58:40 Creating Terraform AWS Provider (SDKv2-style)...
2025/09/17 09:58:40 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccLambdaInvokeAction_basic
=== PAUSE TestAccLambdaInvokeAction_basic
=== RUN   TestAccLambdaInvokeAction_withQualifier
=== PAUSE TestAccLambdaInvokeAction_withQualifier
=== RUN   TestAccLambdaInvokeAction_invocationTypes
=== PAUSE TestAccLambdaInvokeAction_invocationTypes
=== RUN   TestAccLambdaInvokeAction_logTypes
=== PAUSE TestAccLambdaInvokeAction_logTypes
=== RUN   TestAccLambdaInvokeAction_clientContext
=== PAUSE TestAccLambdaInvokeAction_clientContext
=== RUN   TestAccLambdaInvokeAction_complexPayload
=== PAUSE TestAccLambdaInvokeAction_complexPayload
=== CONT  TestAccLambdaInvokeAction_basic
=== CONT  TestAccLambdaInvokeAction_logTypes
=== CONT  TestAccLambdaInvokeAction_complexPayload
=== CONT  TestAccLambdaInvokeAction_invocationTypes
=== CONT  TestAccLambdaInvokeAction_withQualifier
=== CONT  TestAccLambdaInvokeAction_clientContext
--- PASS: TestAccLambdaInvokeAction_withQualifier (29.12s)
--- PASS: TestAccLambdaInvokeAction_clientContext (34.58s)
--- PASS: TestAccLambdaInvokeAction_logTypes (49.21s)
--- PASS: TestAccLambdaInvokeAction_basic (53.73s)
--- PASS: TestAccLambdaInvokeAction_complexPayload (60.50s)
--- PASS: TestAccLambdaInvokeAction_invocationTypes (63.35s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	68.836s

jar-b
jar-b approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YakDriver YakDriver merged commit e81d06b into main Sep 17, 2025
65 checks passed
@YakDriver YakDriver deleted the f-ec2-instance-action branch September 17, 2025 14:34
@github-actions GitHub Actions
Copy link
Contributor

Warning

This Issue has been closed, meaning that any additional comments are much easier for the maintainers to miss. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v6.14.0 milestone Sep 17, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v6.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jar-b jar-b jar-b approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/ce Issues and PRs that pertain to the ce service. service/elasticache Issues and PRs that pertain to the elasticache service. service/iam Issues and PRs that pertain to the iam service. service/mediaconvert Issues and PRs that pertain to the mediaconvert service. service/memorydb Issues and PRs that pertain to the memorydb service. service/securityhub Issues and PRs that pertain to the securityhub service. service/workspaces Issues and PRs that pertain to the workspaces service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v6.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YakDriver @jar-b