-
Notifications
You must be signed in to change notification settings - Fork 36
Simplify actions to one schema type #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I left some comments of additional things to delete / adjust, but that doesn't need to block this PR. Just sometime before release 👍🏻 (I'll reapprove if you do decide to adjust it here)
// regarding optionally supported protocol features for the InvokeAction RPC, | ||
// such as forward-compatible Terraform behavior changes. | ||
// | ||
// Maintainer Note: This is in the protocol in Terraform Core, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice note, answered my question 😆
ref: hashicorp/terraform#37602
Removes other action schema types to match the Terraform core side of the prototype, as well as the concept of linked resources.