-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enhance purechecks for CryptoGetAccountBalanceHandler #12839
Merged
thomas-swirlds-labs
merged 13 commits into
release/0.49
from
12715-enhance-pureChecks-for-CryptoGetAccountBalanceHandler
Apr 24, 2024
Merged
feat: Enhance purechecks for CryptoGetAccountBalanceHandler #12839
thomas-swirlds-labs
merged 13 commits into
release/0.49
from
12715-enhance-pureChecks-for-CryptoGetAccountBalanceHandler
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
…etAccountBalanceHandler
mhess-swl
reviewed
Apr 19, 2024
...ain/java/com/hedera/node/app/service/token/impl/handlers/CryptoGetAccountBalanceHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/com/hedera/node/app/service/token/impl/handlers/CryptoGetAccountBalanceHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/com/hedera/node/app/service/token/impl/handlers/CryptoGetAccountBalanceHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/com/hedera/node/app/service/token/impl/handlers/CryptoGetAccountBalanceHandler.java
Outdated
Show resolved
Hide resolved
...ain/java/com/hedera/node/app/service/token/impl/handlers/CryptoGetAccountBalanceHandler.java
Show resolved
Hide resolved
...com/hedera/node/app/service/token/impl/test/handlers/CryptoGetAccountBalanceHandlerTest.java
Show resolved
Hide resolved
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
…ptoGetAccountBalanceHandler' into 12715-enhance-pureChecks-for-CryptoGetAccountBalanceHandler
…etAccountBalanceHandler
...ain/java/com/hedera/node/app/service/token/impl/handlers/CryptoGetAccountBalanceHandler.java
Outdated
Show resolved
Hide resolved
mhess-swl
previously approved these changes
Apr 22, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
…etAccountBalanceHandler
Neeharika-Sompalli
previously approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks @thomas-swirlds-labs
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
…ptoGetAccountBalanceHandler' into 12715-enhance-pureChecks-for-CryptoGetAccountBalanceHandler
…etAccountBalanceHandler
mhess-swl
approved these changes
Apr 23, 2024
…etAccountBalanceHandler
thomas-swirlds-labs
deleted the
12715-enhance-pureChecks-for-CryptoGetAccountBalanceHandler
branch
April 24, 2024 13:22
thomas-swirlds-labs
added a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
thomas-swirlds-labs
added a commit
that referenced
this pull request
May 8, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
thomas-swirlds-labs
added a commit
that referenced
this pull request
May 9, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adding additional pure checks to CryptoGetAccountBalanceHandler and associated Unit and Hapi Tests.
Related issue(s):
Fixes #12715
Checklist