Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhance purechecks for CryptoGetAccountBalanceHandler #12839

Conversation

thomas-swirlds-labs
Copy link
Contributor

Description:
Adding additional pure checks to CryptoGetAccountBalanceHandler and associated Unit and Hapi Tests.

Related issue(s):

Fixes #12715

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Copy link

github-actions bot commented Apr 16, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✔️  6m 43s ⏱️
2 suites  0 💤
2 files    0

Results for commit 9e7e68f.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 16, 2024

Node: HAPI Test (Node Death Reconnect) Results

1 tests   1 ✔️  26s ⏱️
1 suites  0 💤
2 files    0
1 errors

For more details on these parsing errors, see this check.

Results for commit 9e319ae.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 16, 2024

Node: HAPI Test (Token) Results

215 tests   214 ✔️  20m 25s ⏱️
  16 suites      1 💤
  16 files        0

Results for commit 9e319ae.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 16, 2024

Node: HAPI Test (Crypto) Results

220 tests   220 ✔️  26m 5s ⏱️
  23 suites      0 💤
  23 files        0

Results for commit 9e319ae.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 16, 2024

Node: HAPI Test (Misc) Results

437 tests   427 ✔️  40m 34s ⏱️
  75 suites    10 💤
  75 files        0

Results for commit 9e319ae.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 16, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✔️  54m 12s ⏱️
  3 suites    0 💤
  3 files      0

Results for commit 9e319ae.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 16, 2024

Node: HAPI Test (Smart Contract) Results

505 tests   502 ✔️  1h 6m 8s ⏱️
  55 suites      3 💤
  55 files        0

Results for commit 9e319ae.

♻️ This comment has been updated with latest results.

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
@thomas-swirlds-labs thomas-swirlds-labs marked this pull request as ready for review April 19, 2024 11:12
@thomas-swirlds-labs thomas-swirlds-labs requested a review from a team April 19, 2024 11:12
@thomas-swirlds-labs thomas-swirlds-labs requested a review from a team as a code owner April 19, 2024 11:12
Copy link

github-actions bot commented Apr 19, 2024

Node: Unit Test Results

    2 266 files  ±0      2 266 suites  ±0   3h 43m 34s ⏱️ - 10m 54s
112 208 tests +1  112 159 ✔️ +1  49 💤 ±0  0 ±0 
120 670 runs  +1  120 621 ✔️ +1  49 💤 ±0  0 ±0 

Results for commit 9e319ae. ± Comparison against base commit f0bc71e.

♻️ This comment has been updated with latest results.

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
…ptoGetAccountBalanceHandler' into 12715-enhance-pureChecks-for-CryptoGetAccountBalanceHandler
mhess-swl
mhess-swl previously approved these changes Apr 22, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks @thomas-swirlds-labs

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
…ptoGetAccountBalanceHandler' into 12715-enhance-pureChecks-for-CryptoGetAccountBalanceHandler
@thomas-swirlds-labs thomas-swirlds-labs merged commit b41f60e into release/0.49 Apr 24, 2024
38 of 43 checks passed
@thomas-swirlds-labs thomas-swirlds-labs deleted the 12715-enhance-pureChecks-for-CryptoGetAccountBalanceHandler branch April 24, 2024 13:22
@thomas-swirlds-labs thomas-swirlds-labs self-assigned this May 8, 2024
thomas-swirlds-labs added a commit that referenced this pull request May 8, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
thomas-swirlds-labs added a commit that referenced this pull request May 8, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
thomas-swirlds-labs added a commit that referenced this pull request May 9, 2024
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
thomas-swirlds-labs added a commit that referenced this pull request May 9, 2024
…ler (#12839) (#13143)

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
thomas-swirlds-labs added a commit that referenced this pull request May 9, 2024
…ler (#12839) into release 50 (#13171)

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
stoyanov-st pushed a commit that referenced this pull request May 15, 2024
…ler (#12839) (#13143)

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Stanimir Stoyanov <stanimir.stoyanov@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate and Update pureChecks() in CryptoGetAccountBalanceHandler
3 participants