Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (cherry pick) Enhance purechecks for CryptoGetAccountBalanceHandler (#12839) into 50 #13155

Conversation

thomas-swirlds-labs
Copy link
Contributor

Description:

Cherry Pick of #12839 from 0.49 into 0.50

Neeharika-Sompalli and others added 2 commits May 7, 2024 09:40
)

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
@thomas-swirlds-labs thomas-swirlds-labs requested a review from a team May 8, 2024 19:31
@thomas-swirlds-labs thomas-swirlds-labs requested review from a team as code owners May 8, 2024 19:31
Copy link

github-actions bot commented May 8, 2024

Node: HAPI Test (Restart) Results

2 tests   2 ✅  7m 5s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 207152c.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented May 8, 2024

Node: HAPI Test (Node Death Reconnect) Results

2 tests   2 ✅  7m 30s ⏱️
2 suites  0 💤
2 files    0 ❌

Results for commit 1b171c1.

Copy link

github-actions bot commented May 8, 2024

Node: HAPI Test (Token) Results

235 tests   234 ✅  20m 58s ⏱️
 17 suites    1 💤
 17 files      0 ❌

Results for commit 1b171c1.

Copy link

github-actions bot commented May 8, 2024

Node: HAPI Test (Misc) Results

459 tests   449 ✅  36m 46s ⏱️
 77 suites   10 💤
 77 files      0 ❌

Results for commit 1b171c1.

Copy link

github-actions bot commented May 8, 2024

Node: HAPI Test (Crypto) Results

335 tests   335 ✅  39m 0s ⏱️
 25 suites    0 💤
 25 files      0 ❌

Results for commit 1b171c1.

Copy link

github-actions bot commented May 8, 2024

Node: HAPI Test (Time Consuming) Results

21 tests   21 ✅  54m 34s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 1b171c1.

Copy link

github-actions bot commented May 8, 2024

Node: Unit Test Results

  2 278 files  ±0    2 278 suites  ±0   1h 47m 50s ⏱️ - 1h 48m 12s
118 750 tests +1  118 683 ✅ +1  67 💤 ±0  0 ❌ ±0 
127 235 runs  +1  127 168 ✅ +1  67 💤 ±0  0 ❌ ±0 

Results for commit 1b171c1. ± Comparison against base commit 95ca59c.

This pull request removes 4006 and adds 3770 tests. Note that renamed tests count towards both.

  
             IssuerDN: CN=s-aaaa
            SubjectDN: CN=s-aaaa
           Final Date: Fri Jan 01 00:00:00 UTC 2100
           Public Key: RSA Public Key [2e:28:bc:1e:d3:83:25:92:8e:cb:98:b1:b6:84:06:9c:d5:d8:14:d5],[56:66:d1:a4]
           Start Date: Sat Jan 01 00:00:00 UTC 2000
         SerialNumber: 12482092706667292405
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5e…
        modulus: c1a0ff5d2372b53d12d12bb87dd03f5…
…
com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [4] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [6] 

com.hedera.node.app.grpc.impl.netty.GrpcServiceBuilderTest ‑ [7]   
  
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [10] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@87afdaf1
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [11] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@e4813bc3
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [12] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@9aa8e4ee
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [13] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@ed121a0d
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [14] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@ddebb405
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [15] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@3567f483
com.hedera.node.app.service.mono.state.codec.VirtualKeySerdesAdapterTest ‑ [16] com.hedera.node.app.service.mono.state.codec.VirtualBlobKey@5bd2cf5
…

Copy link

github-actions bot commented May 8, 2024

Node: HAPI Test (Smart Contract) Results

589 tests   589 ✅  1h 10m 12s ⏱️
 63 suites    0 💤
 63 files      0 ❌

Results for commit 1b171c1.

@thomas-swirlds-labs thomas-swirlds-labs self-assigned this May 9, 2024
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not have release/0.50 as its target.

@thomas-swirlds-labs
Copy link
Contributor Author

Good catch @netopyr 👍

@thomas-swirlds-labs thomas-swirlds-labs deleted the cherry-pick-12715-purechecks-CryptoGet-into-50 branch May 9, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants