Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate and Update pureChecks() in CryptoGetAccountBalanceHandler #12715

Closed
Tracked by #12711
mhess-swl opened this issue Apr 10, 2024 · 0 comments · Fixed by #12839
Closed
Tracked by #12711

Validate and Update pureChecks() in CryptoGetAccountBalanceHandler #12715

mhess-swl opened this issue Apr 10, 2024 · 0 comments · Fixed by #12839
Assignees
Labels
Modularization Issues or PRs related to modularization

Comments

@mhess-swl
Copy link
Member

mhess-swl commented Apr 10, 2024

This handler could add the following pure checks:

  • balanceSource != UNSET
  • if balanceSource == ACCOUNT_ID: accountID is valid
    • shard > -1,
    • realm > -1
    • id > 0
    • if (account.kind() == AccountOneOfType.ALIAS) then alias is valid (not null and parseable)
  • if balanceSource == CONTRACT_ID: contractID is valid
@mhess-swl mhess-swl added the Modularization Issues or PRs related to modularization label Apr 10, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Services Team Apr 10, 2024
@mhess-swl mhess-swl moved this from 📋 Backlog to 🏃🏻 Sprint Backlog in Services Team Apr 10, 2024
@thomas-swirlds-labs thomas-swirlds-labs self-assigned this Apr 15, 2024
@thomas-swirlds-labs thomas-swirlds-labs moved this from 🏃🏻 Sprint Backlog to 👷🏼‍♀️ In Progress in Services Team Apr 15, 2024
@thomas-swirlds-labs thomas-swirlds-labs changed the title CryptoGetAccountBalanceHandler Validate and Update pureChecks() in CryptoGetAccountBalanceHandler Apr 15, 2024
@thomas-swirlds-labs thomas-swirlds-labs linked a pull request Apr 16, 2024 that will close this issue
2 tasks
@thomas-swirlds-labs thomas-swirlds-labs moved this from 👷🏼‍♀️ In Progress to 👀 In Review in Services Team Apr 19, 2024
@thomas-swirlds-labs thomas-swirlds-labs moved this from 👀 In Review to ✅ Done in Services Team Apr 24, 2024
@netopyr netopyr moved this from ✅ Done to 👷🏼‍♀️ In Progress in Services Team May 8, 2024
@netopyr netopyr moved this from 👷🏼‍♀️ In Progress to 👀 In Review in Services Team May 8, 2024
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Services Team May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Modularization Issues or PRs related to modularization
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants