Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode in section ids do not reload properly #2198

Closed
vokimon opened this issue Jul 23, 2018 · 1 comment
Closed

unicode in section ids do not reload properly #2198

vokimon opened this issue Jul 23, 2018 · 1 comment

Comments

@vokimon
Copy link

vokimon commented Jul 23, 2018

With history=true reloads keep the slide, which is quite nice when you are editing them. But when the id has some unicode character within, reveal rewrites the url removing such characters from the url hash and reloads to the first slide. This is quite nagging when you are writing a slide and want to see the effects of your changes you just made.

When the id is set to some value, is quite pointless to set it to a different one as it won't go anywhere. Html5 allows "any non-space unicode character" as id. If authors use illegal ids on html4 it's on them.

The need comes from the fact that Pandoc generates section id's from titles, and some of them have such unicode characters. I could ask Pandoc the feature of removing such chars from the id, but as i understand the proper fix is on revealjs.

This is related to #1655.

vokimon added a commit to vokimon/reveal.js that referenced this issue Jul 23, 2018
Don't care about the actual content of id. HTML4 cares, but html5 does not. Even, in html4, is pointless manufacturing a new id to target that indeed it is not there. If the id is not legal searching for it will fail and the effect would be the current behavior.

It fixes  hakimel#2198. About pandoc generated ids based on unicode titles.
@hakimel
Copy link
Owner

hakimel commented Aug 1, 2018

This should be fixed now – see comment in #2199.

@hakimel hakimel closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants