Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ids that starts with a number #1655

Closed
AndreasMadsen opened this issue Aug 5, 2016 · 1 comment
Closed

ids that starts with a number #1655

AndreasMadsen opened this issue Aug 5, 2016 · 1 comment

Comments

@AndreasMadsen
Copy link

As I understand it HTML5 does not set any restrictions on the ID (other than it is unique). Thus I can have an id like 2d and get the hash #/2d. In that case https://github.com/hakimel/reveal.js/blob/master/js/reveal.js#L3285-L3286 will cause it to be parsed as 2 moving, thus navigating to horizontal slide number two.

I don't know what the correct fix is. But it was confusing very when I had my 2d slides as hindex = 3 and when I pressed right it would navigate back to hindex = 2.

@deitch
Copy link

deitch commented Nov 11, 2016

I just got bit by this. Putting together a slide on cloud architectures, wanted a slide on 12-Factor Apps, so I did:

<section id="12factor">
<!-- lots of content here -->
</section>

It wouldn't go to it, just jumped over and got stuck. Took me a while to figure out the problem was starting the ID with a number. It violates html4 per https://www.w3.org/TR/html4/types.html#type-id but since reveal.js is html5, where it is allowed to start with a number (or even be just numbers) per https://www.w3.org/TR/html5/dom.html#the-id-attribute it should work.

@hakimel hakimel closed this as completed in 249f013 Aug 1, 2018
wecacuee pushed a commit to wecacuee/reveal.js that referenced this issue Aug 2, 2019
R0bes pushed a commit to R0bes/Terraform-Presentation that referenced this issue Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants