Fix: Suporting unicode id's #2199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't care about the actual content of id. HTML4 cares, but html5 does not. Even, in html4, is pointless manufacturing a new id to target that indeed it is not there. If the id is not legal searching for it will fail and the effect would be the current behavior. It fixes hakimel#2198. About pandoc generated ids based on unicode titles.
|
Thanks for the PR but this had already been addressed by someone else in fa8a7334ce2ea99a736dd5e72734b08fc01c6fdca. The change was in the dev branch, but I've released it in reveal.js 3.7.0 now. Please give it a shot and let me know if you encounter any issues. |
|
Super. Works like a charm. Even better than my patch. Thanks for the release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reveal should'nt care about the actual content of the slide id (filtering chars which are not ascii letters, numbers or some simbols). HTML4 cares, but html5 does not.
Even, in html4, there is no point in manufacturing a new id to a target that does not exist. If searching for unicode ids does not work, the effect would be the current behavior (going back to the first page).
What it is needed is to urldecode the given hash.
It fixes #2198. About failing to reload slides with Pandoc generated ids, which are based on titles that might contain unicode.