Smaller thumbnail trail images #755
Conversation
|
The most "compatible" way for this is to make sure trails are downloaded as full and then after a week we release a build that properly uses this. |
projects/Mallard/src/components/front/items/trail-image-view.tsx
Outdated
Show resolved
Hide resolved
projects/common/src/index.ts
Outdated
| @@ -396,26 +420,27 @@ export const frontPath = (issue: string, frontId: string) => | |||
|
|
|||
| // These have issueids in the path, but you'll need to change the archiver if you want to use them. | |||
|
|
|||
| //To remove. | |||
There was a problem hiding this comment.
never, :(
I was planning on moving media to images/${size}/full-size
but instead I just moved all the others to thumbs/${size}/${use}
this means that the image paths don't change for full size images
| ...props | ||
| }: ImageResourceProps) => { | ||
| const [width, setWidth] = useState<number | null>(null) | ||
| const imagePath = useImagePath(image) | ||
| const imagePath = useImagePath(image, 'full-size') //TODO: This should be changed to use once we have a good amount of content published with trail thumbs |
There was a problem hiding this comment.
Can we determine what this is and add a timed trello card for it?
There was a problem hiding this comment.
I can make the comment clearer, but I meant the variable use from line 55.
| @@ -212,7 +212,7 @@ const OpinionSuper = ({ article, ...tappableProps }: PropTypes) => { | |||
| ) | |||
| } | |||
|
|
|||
| const SuperHeroImageItem = (props: PropTypes) => { | |||
| export const SuperHeroImageItem = (props: PropTypes) => { | |||
There was a problem hiding this comment.
This change doesnt follow the patterns used in the rest of the code base.
There was a problem hiding this comment.
We had this conversation when I started on this PR where we agreed on export const
| use: { mobile: 'full-size', tablet: 'thumb' }, | ||
| } | ||
| const article: CAPIArticle = { | ||
| key: '🔑', |
There was a problem hiding this comment.
Emojis are nice to look at, but not inline with real data.
There was a problem hiding this comment.
This is consistent with the other tests in the file.
| @@ -63,13 +65,3 @@ export const getImage = async ( | |||
|
|
|||
| return [path, await maybeResponse.buffer()] | |||
| } | |||
|
|
|||
| export const getColours = async ( | |||
There was a problem hiding this comment.
Was this removed on purpose? Seems to not be removed anywhere else.
There was a problem hiding this comment.
It turned out not to be used anywhere, so I got rid of it as it was in the way when making the PR.
AWare
force-pushed
the
aw-trail-2
branch
2 times, most recently
from
5e84b76
to
3776ace
Compare
|
@jimhunty changes made, can I get the +1 please? |
author Alex Ware <alex.ware@guardian.co.uk> 1571648155 +0100 committer Alex Ware <alex.ware@guardian.co.uk> 1572441783 +0000 Smaller thumbnail trail images don't break thumbs in existing installs or existing content downloaded archiver fixes oops fix lint and test pr changes pr comment fix build fix test?
Part 2 of #658
Replaces #673 which had a rebase accident.
thumbandlarge-thumbusePerformance:
This saves a small amount of RAM, but noticeably decreases image load time on android.