Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually use the use param #783

Merged
merged 1 commit into from
Nov 28, 2019
Merged

Actually use the use param #783

merged 1 commit into from
Nov 28, 2019

Conversation

AWare
Copy link
Contributor

@AWare AWare commented Oct 30, 2019

This puts #755 into action. Merge after 6th Nov.

@AWare AWare added the ⛔️ Do not merge More work needed or proof of concept label Oct 30, 2019
@jimhunty
Copy link
Contributor

jimhunty commented Nov 8, 2019

@AWare Should we merge this now?

@AWare
Copy link
Contributor Author

AWare commented Nov 11, 2019

Yes, this should be merged for the next release.

@AWare AWare removed the ⛔️ Do not merge More work needed or proof of concept label Nov 11, 2019
@jeanlauliac
Copy link
Contributor

@AWare @jimhunty let's merge?

@AWare
Copy link
Contributor Author

AWare commented Nov 27, 2019

I'm happy to, but no longer know the process.

@philmcmahon
Copy link
Contributor

I've run this locally and checked that pictures are still there and look ok!

@philmcmahon philmcmahon merged commit 7f29cf3 into master Nov 28, 2019
@philmcmahon philmcmahon deleted the aw-trail-3 branch November 28, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants