Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail image routing #673

Closed
wants to merge 1 commit into from
Closed

Thumbnail image routing #673

wants to merge 1 commit into from

Conversation

AWare
Copy link
Contributor

@AWare AWare commented Oct 9, 2019

Part 2 of #658

So far:

  • Adds a path /images to replace /media which also takes a param use
  • Adds a 'thumbs' directory for thumb and large-thumb
  • Changes resizer parameters based on use
  • Puts these new paths into s3 / zips
  • Uses these new paths in the Image path code
  • Makes guesses about which use goes where

To do:

  • Make 100% sure we use the right use in the right place
  • Test performance characteristics
  • Pick sensible sizes for images

Post PR:
- Remove media from backend
- Remove media from archiver
- Deprecate old version
The API change is non breaking now so doesn't require a follow up

@AWare AWare force-pushed the aw-trail-image-routing branch 2 times, most recently from 8f4d896 to 80ee64c Compare October 11, 2019 15:50
@AWare AWare added the ⛔️ Do not merge More work needed or proof of concept label Oct 15, 2019
@AWare AWare marked this pull request as ready for review October 17, 2019 13:13
@AWare AWare force-pushed the aw-trail-image-routing branch 3 times, most recently from cdc5ac5 to 5787938 Compare October 18, 2019 11:27
Add new route for images with use and remove colour controller (unused)

clean up and add new image functions

put it alllll in a zip

fix test

fix imports from rebase

restore lukes test?

debug what is in the zip

source map in archiver

fix rebase issue

fix image path

Simplify zipper

more logging

Fix silly prefix bug

Better local

Fix everything in tablet again

Just start using images with uses in the app instead of media

dont do that

reorder imports

move full sized back to media

fix compillation

log?

handle multiple pages and prefixes

more progress

rebase fixes

guess sizes

put use back in trail image

Uses in app
@AWare
Copy link
Contributor Author

AWare commented Oct 21, 2019

I've not had a rebase do that before 😭

@AWare AWare closed this Oct 21, 2019
@jimhunty jimhunty deleted the aw-trail-image-routing branch April 19, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ Do not merge More work needed or proof of concept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants