Theme material-nf3 #1728

bim9262 · 2023-02-18T07:09:54Z

The nf-mdi-* icons have been deprecated. This commit exchanges them
for their nf-md counterparts.

Add thermometer progression for material-nf

ammgws · 2023-02-18T07:20:42Z

In reference to this: ryanoasis/nerd-fonts#1096 / ryanoasis/nerd-fonts#773 ?

What was the difference between nf-mdi and nf-md? I can't remember...

bim9262 · 2023-02-18T07:29:47Z

Yes, I think that they moved the old mdi icons to a new region so they renamed them all to just md so the names wouldn't overlap as well. I will note that the new icons do render a bit smaller than the old ones.

ammgws · 2023-02-18T07:32:42Z

I will note that the new icons do render a bit smaller than the old ones.

Apparently...
ryanoasis/nerd-fonts#1061

I imagine getting a few bug reports from that alone..

files/icons/material-nf.toml

Finii · 2023-02-20T09:21:21Z

I will fix 1061 before v3.0.0 goes out.

bim9262 · 2023-02-23T04:24:24Z

Perhaps this should become a new theme, material-nf3?

ammgws · 2023-02-23T04:33:35Z

So if nerd fonts v3.0.0 is going to not just deprecate but also remove the codepoints that we are currently using then we should probably create material-nf3.

bim9262 · 2023-02-23T05:02:56Z

v2 does write glyphs outside of the PUA. As noted on ryanoasis/nerd-fonts#365:

It is the problem that font_patcher writes glyphs from Material into the range: U+F500 - U+FD46. This range overlaps areas that should not use for such purpose.

One of the last comments from @Finii:

Yes, according to plan this will come (glyphs removed) with v3.0.0, this was just one necessary intermediate step.

So, if I understand correctly, some of the codepoints we use in today's material-nf will be removed in v3.

Finii · 2023-02-23T07:44:44Z

@bim9262

Citation from https://github.com/ryanoasis/nerd-fonts/releases

Codepoint 'translation list' can be found here: ryanoasis/nerd-fonts#1059 (comment)

Edit: Add translation list link

bim9262 · 2023-02-23T13:28:01Z

Thanks @Finii!!

@ammgws, I'll rename this material-nf3

[why] The Material Design Icons have for sure pairs of glyphs that people would like to have scaled identically. Because the sheer number of glyphs and because they are already very nicely and uniformly scaled within their design space the MDI at the new codepoints where all scaled the same with taking the theoretical design space as ScaleGlyph. But that means all icons get scaled a bit smaller than before, where we individually scaled each Material Design Icon to fill the cell. This lead to numerous complaints. [how] We take a different approach now, more conventional maybe. Especially in the light that the older bigger icons will get dropped; and people love them. So the uniform scaling is ditched and the individual scaling is used. Fixes: #1061 Note: greshake/i3status-rust#1728 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

bim9262 · 2023-02-23T23:59:47Z

Looks great @Finii, thanks!!

If anyone else wants to test and hasn't built a font before, this is what I did on arch:

sudo pacman -S fontforge
cd /tmp
git clone --depth 1 https://github.com/ryanoasis/nerd-fonts.git
cd nerd-fonts
./font-patcher -s -ext ttf -c -out ~/.local/share/fonts/ src/unpatched-fonts/NerdFontsSymbolsOnly/NerdFontsSymbols\ 2048\ EM\ Nerd\ Font\ Complete\ Blank.sfd

Restart i3status-rust

bim9262 · 2023-03-06T05:23:34Z

@MaxVerevkin, @ammgws,

Anything that should be done before this is merged?

Finii · 2023-03-06T09:14:49Z

If anyone else wants to test and hasn't built a font before, this is what I did on arch:

sudo pacman -S fontforge
cd /tmp
git clone --depth 1 https://github.com/ryanoasis/nerd-fonts.git
cd nerd-fonts
./font-patcher -s -ext ttf -c -out ~/.local/share/fonts/ src/unpatched-fonts/NerdFontsSymbolsOnly/NerdFontsSymbols\ 2048\ EM\ Nerd\ Font\ Complete\ Blank.sfd

Cloning the repo even with depth 1 is rather time consuming. I would recomment using the docker image (well, that needs some docker setup), or

 sudo pacman -S fontforge
 cd /tmp
-git clone --depth 1 https://github.com/ryanoasis/nerd-fonts.git
+mkdir nerd-fonts
 cd nerd-fonts
+curl -LO https://github.com/ryanoasis/nerd-fonts/raw/master/FontPatcher.zip 
+unzip FontPatcher.zip
 ./font-patcher -s -ext ttf -c -out ~/.local/share/fonts/ src/unpatched-fonts/NerdFontsSymbolsOnly/NerdFontsSymbols\ 2048\ EM\ Nerd\ Font\ Complete\ Blank.sfd

Edit: Oh sorry, I see you use the empty template .sfd, which is of course not in the zip archive. So this is not really helpful, except you want to patch something you already have.

ammgws · 2023-03-06T10:54:21Z

@MaxVerevkin, @ammgws,

Anything that should be done before this is merged?

I was thinking perhaps we should instead keep material-nf pointed towards the latest version, and instead introduce material-nf2.3 as a legacy option instead.

bim9262 · 2023-03-07T00:45:06Z

We may want to wait until the next nerd-fonts release so that we don't have complaints about the small icons. (I imagine most people haven't installed them from src)

bim9262 · 2023-03-21T01:11:46Z

Just saw

i3status-rust/files/icons/material-nf.toml

Lines 73 to 79 in 4e45727

    
           net_wireless = [ 
        
           	"\U000F092F", # nf-md-wifi_strength_outline 
        
           	"\U000F091F", # nf-md-wifi_strength_1 
        
           	"\U000F0922", # nf-md-wifi_strength_2 
        
           	"\U000F0925", # nf-md-wifi_strength_3 
        
           	"\U000F0928", # nf-md-wifi_strength_4 
        
           ]

. We might just end up with this commit done piecemeal. Do we want to keep nf-md-* out of material-nf.toml still? It feels like we'll muddle the line between material-nf2.3.toml and material-nf.toml.

MaxVerevkin · 2023-03-22T16:06:32Z

Do we want to keep nf-md-* out of material-nf.toml still?

If I understand it correctly, the reason we don't just switch to nf-md-* is icons' size. I didn't notice any scaling issues with the wifi icons, so I added them. If the scaling issues will be resolved, I see no point in splitting material-nf in two themes.

ammgws · 2023-04-07T22:28:07Z

The split was aimed at people using specific distros where they might have nerdfonts in the repo but not i3status-rust, and end up with the former lagging behind the latter which would be updated by the user. But I just checked the nerd-fonts repo and it seems like it's not even in Debian or Ubuntu repos (the usual suspects) so maybe we don't need to keep the legacy icon set?

bim9262 · 2023-04-08T07:40:33Z

All of the codepoints we're using (both nf-mdi and nf-md) are available in 2.3, so as long as the major repos that have nerdfonts are at least that up to date it shouldn't be required to keep two icon sets around.

ammgws · 2023-04-08T08:25:58Z

Ok that makes things simpler then

The `nf-mdi-*` icons have been deprecated as of `v2.3.x`. This commit exchanges them for their `nf-md` counterparts. From https://github.com/ryanoasis/nerd-fonts/releases/tag/v2.3.3: > The `v2.3.x` release has both, the 'old' and the 'new' codepoints to > enable you an easier transition. Please change already now your > prompts and other uses to the new codepoints. Release `v3.0.0` will > finally drop the old codepoints (`F500` - `FD46`).

bim9262 · 2023-04-30T23:03:25Z

v3.0.0 has been released, congratulations @Finii!

MaxVerevkin · 2023-05-01T07:31:33Z

Yay, Nerd Font Propo makes spacing even without icons_format hacks 🎉

[why] The Material Design Icons have for sure pairs of glyphs that people would like to have scaled identically. Because the sheer number of glyphs and because they are already very nicely and uniformly scaled within their design space the MDI at the new codepoints where all scaled the same with taking the theoretical design space as ScaleGlyph. But that means all icons get scaled a bit smaller than before, where we individually scaled each Material Design Icon to fill the cell. This lead to numerous complaints. [how] We take a different approach now, more conventional maybe. Especially in the light that the older bigger icons will get dropped; and people love them. So the uniform scaling is ditched and the individual scaling is used. Fixes: ryanoasis#1061 Note: greshake/i3status-rust#1728 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

MaxVerevkin added the themes/icons label Feb 18, 2023

MaxVerevkin reviewed Feb 18, 2023

View reviewed changes

files/icons/material-nf.toml Show resolved Hide resolved

bim9262 mentioned this pull request Feb 23, 2023

Add new emoji icon set 🙂 #1729

Merged

Finii mentioned this pull request Feb 23, 2023

font-patcher: Scale all Material Design Icons individually ryanoasis/nerd-fonts#1133

Merged

2 tasks

bim9262 force-pushed the theme_material-nf branch from 11778c6 to f65a6fc Compare February 23, 2023 23:24

bim9262 changed the title ~~Theme material nf~~ Theme material-nf3 Feb 24, 2023

bim9262 force-pushed the theme_material-nf branch from f65a6fc to 0346894 Compare February 24, 2023 21:59

bim9262 force-pushed the theme_material-nf branch from 0346894 to 39d876a Compare March 7, 2023 00:43

bim9262 marked this pull request as draft March 7, 2023 00:45

bim9262 force-pushed the theme_material-nf branch from 39d876a to b36ba34 Compare March 21, 2023 01:13

bim9262 force-pushed the theme_material-nf branch from b36ba34 to c6134d2 Compare March 24, 2023 15:42

MaxVerevkin mentioned this pull request Apr 17, 2023

The codepoints for material-nf will have to move before nerd-fonts 3.0.0 #1869

Closed

bim9262 linked an issue Apr 19, 2023 that may be closed by this pull request

The codepoints for material-nf will have to move before nerd-fonts 3.0.0 #1869

Closed

bim9262 added 2 commits April 19, 2023 17:58

Add thermometer progression

dc50593

bim9262 force-pushed the theme_material-nf branch from c6134d2 to dc50593 Compare April 19, 2023 23:06

bim9262 marked this pull request as ready for review April 30, 2023 23:02

MaxVerevkin merged commit c99b610 into greshake:master May 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Theme material-nf3 #1728

Theme material-nf3 #1728

bim9262 commented Feb 18, 2023

ammgws commented Feb 18, 2023 •

edited

Loading

bim9262 commented Feb 18, 2023

ammgws commented Feb 18, 2023

Finii commented Feb 20, 2023

bim9262 commented Feb 23, 2023

ammgws commented Feb 23, 2023

bim9262 commented Feb 23, 2023 •

edited

Loading

Finii commented Feb 23, 2023 •

edited

Loading

bim9262 commented Feb 23, 2023

bim9262 commented Feb 23, 2023

bim9262 commented Mar 6, 2023

Finii commented Mar 6, 2023 •

edited

Loading

ammgws commented Mar 6, 2023

bim9262 commented Mar 7, 2023

bim9262 commented Mar 21, 2023

MaxVerevkin commented Mar 22, 2023

ammgws commented Apr 7, 2023

bim9262 commented Apr 8, 2023

ammgws commented Apr 8, 2023

bim9262 commented Apr 30, 2023

MaxVerevkin commented May 1, 2023

Theme material-nf3 #1728

Theme material-nf3 #1728

Conversation

bim9262 commented Feb 18, 2023

ammgws commented Feb 18, 2023 • edited Loading

bim9262 commented Feb 18, 2023

ammgws commented Feb 18, 2023

Finii commented Feb 20, 2023

bim9262 commented Feb 23, 2023

ammgws commented Feb 23, 2023

bim9262 commented Feb 23, 2023 • edited Loading

Finii commented Feb 23, 2023 • edited Loading

bim9262 commented Feb 23, 2023

bim9262 commented Feb 23, 2023

bim9262 commented Mar 6, 2023

Finii commented Mar 6, 2023 • edited Loading

ammgws commented Mar 6, 2023

bim9262 commented Mar 7, 2023

bim9262 commented Mar 21, 2023

MaxVerevkin commented Mar 22, 2023

ammgws commented Apr 7, 2023

bim9262 commented Apr 8, 2023

ammgws commented Apr 8, 2023

bim9262 commented Apr 30, 2023

MaxVerevkin commented May 1, 2023

ammgws commented Feb 18, 2023 •

edited

Loading

bim9262 commented Feb 23, 2023 •

edited

Loading

Finii commented Feb 23, 2023 •

edited

Loading

Finii commented Mar 6, 2023 •

edited

Loading