font-patcher: Scale all Material Design Icons individually #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] The Material Design Icons have for sure pairs of glyphs that people would like to have scaled identically. Because the sheer number of glyphs and because they are already very nicely and uniformly scaled within their design space the MDI at the new codepoints where all scaled the same with taking the theoretical design space as ScaleGlyph. But that means all icons get scaled a bit smaller than before, where we individually scaled each Material Design Icon to fill the cell. This lead to numerous complaints. [how] We take a different approach now, more conventional maybe. Especially in the light that the older bigger icons will get dropped; and people love them. So the uniform scaling is ditched and the individual scaling is used. Fixes: #1061 Note: greshake/i3status-rust#1728 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>
|
For the non-Mono font there is no change because that will only scale down if the symbol is wider than 2 cells, which is impossible by their design (for all 'normal' to be patched fonts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why]
The Material Design Icons have for sure pairs of glyphs that people would like to have scaled identically. Because the sheer number of glyphs and because they are already very nicely and uniformly scaled within their design space the MDI at the new codepoints where all scaled the same with taking the theoretical design space as ScaleGlyph.
But that means all icons get scaled a bit smaller than before, where we individually scaled each Material Design Icon to fill the cell. This lead to numerous complaints.
[how]
We take a different approach now, more conventional maybe. Especially in the light that the older bigger icons will get dropped; and people love them.
So the uniform scaling is ditched and the individual scaling is used.
Fixes: #1061
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
greshake/i3status-rust#1728
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)