Add New Material Design Icons to its own region #773

earboxer · 2022-01-27T14:33:32Z

Description

This is an alternative to #772 . It's part of "Plan 5" Plus in #365. (another part would be to remove the old icons when we make the breaking change).

Requirements / Checklist

Read the Contributing Guidelines
Verified the license of any newly added font, glyph, or glyph set

What does this Pull Request (PR) do?

Add the updated material design icons in its canonical location.

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Fixes #365

and Fixes #279

But it doesn't make any breaking changes, so this can be merged before the 3.0 release

Screenshots (if appropriate or helpful)

readme.md

Finii · 2022-01-27T17:27:02Z

I am always a bit in fear when fonts originate from webfont people. As they often do not care about codepoints and codepoint consistency (they reference glyphs by name, rather).

I examined 3 releases: 3.4.93, 4.6.95, 6.1.95 and they all differ slightly (apart from the switch to F0001), the worst is the drop of one glyph with renumbering all following ones, is that what you noticed? Between 4.x and 6.x

And then individual glyphs are replaced all over now and then, Notes become Cooking Pot, No Entry becomes No PianoKeys, Flower Pot? becomes Flag With Star ... just in the few glyphs shown above.
And that is in all releases.

So ... is this really a basis to use?

Edit: Highlight changed icons in screeenshot

Finii · 2022-01-27T17:44:51Z

Maybe I'm too skeptic with the random changes in the comment above. I could not find any changes in more recent versions. Possibly they underwent some restructuring.

What I do not like too much, but that is personal, is that the svg-to-ttf is hidden in a npm thing, but I wanted to check how they keep the glyph codepoints constant. But when I read npm, my eyes glaze over and I suddenly loose all interest.)

earboxer · 2022-01-27T17:58:14Z

I wanted to check how they keep the glyph codepoints constant

MaterialDesign has a meta.json (similar format that a lot of the FontAwesome-derivatives have).

With a little jq-foo:

jq 'map([.name,.codepoint])' <meta.json

But it seems like they manage their repo using external tools, so, yeah, valid concerns.

Finii · 2022-01-27T18:00:34Z

Scrolling through all the glyphs...
I believe that it needs to utilize some ScaleGlyph stuff, or some pairs will become unusable.
Yes, the current one also misses it.

Maybe one ('old style') ScaleGlyph is enough, because all icons maintain a general good same-scale.

New Note: The old style ScaleGlyph is also broken 😒

Edit: Add note

Finii · 2022-10-06T08:05:08Z

Rebase on master
Use desktop font instead of webfont
Create cheat sheet data
Force push

Finii · 2022-10-06T08:12:45Z

Thanks for this (and the other 772) PR.
Finally we start moving, sorry for the long wait.

There is still some unsolved problem with the scaleGlyph. A lot of paired-symbols look bad if you use them together. In principle the scaleGlyph should fix it, but ... it has problems. #837 tried to solve it, partially, and the same issue came up in #916.

Edit: Ah I already mentioned it here: #773 (comment)

Finii · 2022-11-17T21:21:29Z

Note to self: Is the cheat sheet rendering still ok with 5 digit codes?

Edit: It is.

Finii · 2023-01-06T16:58:37Z

Rebase on master, force push

Finii · 2023-01-06T17:07:02Z

(As expected) scaling broken, refer same glyphs in comment above

Introducing ScaleGlyph or ScaleGroup lets see

Finii · 2023-01-06T18:33:55Z

Material Design Icons has a bug in one glyph:

(That strange horizontal line)

[why] In some cases only some ScaleRule glyphs are used. [how] Store mixture of integers and ranges for ScaleGlyph (as is done for ScaleGroups). Correctly evaluate mixture of integers and ranges. [note] Came up with PR #773 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-01-07T08:54:57Z

Pulled bugfix 05a9ec8 already to master. Rebase, force push.

With appropriate codepoint (fix ryanoasis#365)

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] We want to differentiate between the old, problematic Material Design Icons (problematic because we map them to unicode blocks that we should not), and a future new and updated set of Material Design Icons. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] Material Design Icons has grown quite a bit. [how] Add the icons at their original position which is in PUA1. Use the desktop font instead of the webfont. Add cheat cheat file. Fixes: ryanoasis#365 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] The files sizes of otf files are (especially with the addition of the current Material Design Icons) big enough already. The autohints are not really useful for symbols, so we can drop them and save some space. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] ScaleGlyph always did scaling only (no translation) based on one reference glyph. ScaleGroups does scaling and translation but can not work with one reference glyph but constructs always a combined bounding box. Missing is a way to scale AND translate, but with only one reference glyph. [how] Invent GlyphsToScale+ keyword, that supports just that. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] Scaling the glyphs individually breaks a lot of glyph pairs or groups, for example F0718-F071E. [how] Use one ScaleGlyph for the complete set. The set itself is already very well scaled, i.e. all glyphs are maximized in a given design space and that they look good next to pairing glyphs. There is no need to use ScaleRules which is quite costly for such a big range of glyphs (they all are copied twice in the process). Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii · 2023-01-13T12:32:42Z

Rebase on master, force push.
We near us a merge and also a release 🎉

Finii · 2023-01-14T14:44:13Z

This seems to be stuck: Templarian/MaterialDesign-Font#9

So we might need to fix it on our own.

[why] The glyph 0xF1522 is broken. See: ryanoasis#773 (comment) Templarian/MaterialDesign-Font#9 [how] Manually edit in fontforge and remove line. Export as simple ttf. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] In some cases only some ScaleRule glyphs are used. [how] Store mixture of integers and ranges for ScaleGlyph (as is done for ScaleGroups). Correctly evaluate mixture of integers and ranges. [note] Came up with PR ryanoasis#773 Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

[why] The glyph 0xF1522 is broken. See: ryanoasis#773 (comment) Templarian/MaterialDesign-Font#9 [how] Manually edit in fontforge and remove line. Export as simple ttf. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Add New Material Design Icons to its own region

Finii reviewed Jan 27, 2022

View reviewed changes

readme.md Show resolved Hide resolved

This was referenced Sep 22, 2022

[Suggestion] Fix invalid code points for some glyphs #365

Closed

Update Symbols-2048-em Nerd Font Complete.ttf #609

Closed

Finii added this to the v2.3.0 milestone Sep 24, 2022

Finii force-pushed the new-material branch from dd9e235 to df8927c Compare October 6, 2022 08:04

Finii mentioned this pull request Oct 28, 2022

Hope to add Sarasa-Gothic(更纱黑体) #587

Closed

catesandrew mentioned this pull request Dec 1, 2022

Missing Nerd font icon fabrizioschiavi/pragmatapro#231

Closed

Finii mentioned this pull request Dec 2, 2022

Kubernetes icon looks too small #444

Closed

4 tasks

Finii mentioned this pull request Dec 29, 2022

Missing icons on nerd fonts #1033

Closed

3 tasks

Finii force-pushed the new-material branch from df8927c to 44def15 Compare January 6, 2023 16:58

Finii force-pushed the new-material branch from 35421bc to 5dc09b2 Compare January 7, 2023 08:53

Finii force-pushed the new-material branch from 5dc09b2 to d94e85f Compare January 7, 2023 09:09

Finii mentioned this pull request Jan 7, 2023

Glyph broken Templarian/MaterialDesign-Font#9

Open

earboxer and others added 5 commits January 13, 2023 12:59

materialdesignicons: Update to newer version (fix ryanoasis#279)

5426881

With appropriate codepoint (fix ryanoasis#365)

material design icons: Update documentation

91ae09a

Update generate-glyph-info-from-set to Python 3

5ec943a

Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii added 3 commits January 13, 2023 12:59

Finii force-pushed the new-material branch from d94e85f to 54acb57 Compare January 13, 2023 12:32

This was referenced Jan 13, 2023

Add icon for aws #936

Closed

Add crypto glyphs: Ethereum, Solana, Shiba Inu, Avalanche, etc. #728

Closed

materialdesignicons: Fix glyph F1522

c39c97b

[why] The glyph 0xF1522 is broken. See: ryanoasis#773 (comment) Templarian/MaterialDesign-Font#9 [how] Manually edit in fontforge and remove line. Export as simple ttf. Signed-off-by: Fini Jastrow <ulf.fini.jastrow@desy.de>

Finii merged commit a0b6a5b into ryanoasis:master Jan 15, 2023

This was referenced Jan 22, 2023

New material design icon block icons are much smaller and thus less readable. #1061

Closed

nf-mdi-sleep conflicts with Chinese characters #1070

Closed

Finii mentioned this pull request Feb 4, 2023

Material set conflicts with Persian/Hebrew unicode chars #478

Closed

ammgws mentioned this pull request Feb 18, 2023

Theme material-nf3 greshake/i3status-rust#1728

Merged

antoineco mentioned this pull request Feb 21, 2023

chore: replace deprecated MDI Orbit icon LunarVim/LunarVim#3880

Merged

This was referenced Feb 21, 2023

Update MDI to v3.4.93 (about 1400 extra icons!) #325

Closed

Apple  symbol replacement #492

Closed

This was referenced Mar 29, 2023

Fix obsolete Nerd Font icons lsd-rs/lsd#830

Merged

Prepare for Nerd Fonts 3.0 romkatv/powerlevel10k#2245

Closed

yuma140902 mentioned this pull request Apr 7, 2023

サロゲートペアで表されるNerdFontの文字が豆腐になる yuru7/HackGen#43

Closed

mtoohey31 mentioned this pull request Apr 12, 2023

Replace obsolete icons ogham/exa#1178

Merged

tkapias mentioned this pull request Apr 17, 2023

[Bug] Double width icons and the codepoint change in Nerd Fonts Material Design Icons lsd-rs/lsd#836

Closed

Finii mentioned this pull request May 2, 2023

Some glyphs missing after v3.x.x update #1190

Closed

3 tasks

LNKLEO pushed a commit to LNKLEO/Nerd that referenced this pull request Nov 24, 2023

Merge pull request ryanoasis#773 from earboxer/new-material

bb1748f

Add New Material Design Icons to its own region

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add New Material Design Icons to its own region #773

Add New Material Design Icons to its own region #773

earboxer commented Jan 27, 2022 •

edited

Loading

Finii commented Jan 27, 2022 •

edited

Loading

Finii commented Jan 27, 2022

earboxer commented Jan 27, 2022

Finii commented Jan 27, 2022 •

edited

Loading

Finii commented Oct 6, 2022

Finii commented Oct 6, 2022 •

edited

Loading

Finii commented Nov 17, 2022 •

edited

Loading

Finii commented Jan 6, 2023

Finii commented Jan 6, 2023

Finii commented Jan 6, 2023 •

edited

Loading

Finii commented Jan 7, 2023

Finii commented Jan 13, 2023

Finii commented Jan 14, 2023

Add New Material Design Icons to its own region #773

Add New Material Design Icons to its own region #773

Conversation

earboxer commented Jan 27, 2022 • edited Loading

Description

Requirements / Checklist

What does this Pull Request (PR) do?

How should this be manually tested?

Any background context you can provide?

What are the relevant tickets (if any)?

Screenshots (if appropriate or helpful)

Finii commented Jan 27, 2022 • edited Loading

Finii commented Jan 27, 2022

earboxer commented Jan 27, 2022

Finii commented Jan 27, 2022 • edited Loading

Finii commented Oct 6, 2022

Finii commented Oct 6, 2022 • edited Loading

Finii commented Nov 17, 2022 • edited Loading

Finii commented Jan 6, 2023

Finii commented Jan 6, 2023

Finii commented Jan 6, 2023 • edited Loading

Finii commented Jan 7, 2023

Finii commented Jan 13, 2023

Finii commented Jan 14, 2023

earboxer commented Jan 27, 2022 •

edited

Loading

Finii commented Jan 27, 2022 •

edited

Loading

Finii commented Jan 27, 2022 •

edited

Loading

Finii commented Oct 6, 2022 •

edited

Loading

Finii commented Nov 17, 2022 •

edited

Loading

Finii commented Jan 6, 2023 •

edited

Loading