Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sports_centre and stadium color to green #2954

Merged

Conversation

kocio-pl
Copy link
Collaborator

Now that we use light green for different small leisure areas, we could use it also for big ones, as they typically don't overlap.

That unification would also offload societal_amenities color a bit (so we have less problem defining what it really is) and tie green color closer with the physical activities, which makes the system more predictable.

Examples in Warsaw (with different landuses around):

Before
hr2sr3by
After
qgxsvwqh

Before
ao4jenlr
After
8ix4kxxz

Before
obc7earf
After
ru3lypoj

Before
e01zrfvz
After
marl4vhc

@kocio-pl
Copy link
Collaborator Author

Additional question: should we use italic font for such names? Is it kind of standard for areas (you can see it with school, park, residential and allotments)?

@lakedistrictOSM
Copy link

This looks good, it makes it different from schools and hospitals now. Italics are probably a good idea until we introduce a symbol.

Will this PR change the way leisure=sports_centre + building=yes is rendered?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Dec 6, 2017

No, it changes a color only in the places where yellowish is visible now.

@polarbearing
Copy link
Contributor

You mean it would bring us closer to render societal amenities campuses, ref #1624 ?

I did not like the yellow for sports so much (which happened only recently #2071), thus the green is better. It still does not distinguish a stadium within a surrounding sports_centre #919.

Copy link
Collaborator

@matthijsmelissen matthijsmelissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants