Add sports_centre (@stadium) fill color for leisure=water_park areas

[jeisenbe]

Fixes #1490

Changes proposed in this pull request:

• Add sports_centre (@stadium, =@leisure currently) fill color for leisure=water_park polygons

Explanation:

• According to the wiki, water parks should be mapped as an area; taginfo confirms that over 75% are mapped in this way.
• The current rendering is identical to the rendering of leisure=swimming_area and leisure=sports_centre + sport=swimming, except that the area of the feature is not shown
• The previous discussion in Change leisure=water_park rendering to tourism outline #3748 showed that the tag leisure=water_park is not only used for large theme-park-like tourist attractions, but also for smaller local recreational areas with 1 or 2 pools, plus water slides, therefore rendering the same as zoos and theme parks is not appropriate.

Test rendering with links to the example places:

Piscine de Beaufort, Luxembourg - swimming / water recreating area near campgrounds
z17 before

z17 after

Wild Wild Wet, Singapore - a proper water park, part of a retail mall
https://www.openstreetmap.org/#map=17/1.37794/103.95416
Before z17

After z17

Wet n' Wild Hawaii
https://www.openstreetmap.org/#map=18/21.33557/-158.08670

• this is double-tagged as a theme park, hence the outline.
  Before z15
  

After z15

After z18

Water Works, Science Centre, Singapore
https://www.openstreetmap.org/#map=18/1.33345/103.73657
This is a small water-play / science area in the outdoor courtyard of the Science Centre.
before z18

after z18

[imagico]

I have no objections to this change (rendering leisure=water_park like sports_centre) per se but i am at odds with the use of pale green for things not vegetation related in general because it is confusing to the map user in terms of color systematics.

And it might make sense to fix the color scheme first before going into adding more uses for the current colors leading to constraints in color choices later.

[jeisenbe]

I agree that the current pale green doesn't work well for sports centres or stadiums. It's too low saturation and the lightness is too high, compared to the other colors, and the school/hospital color also has this problem currently.

But since this PR will continue rendering leisure=water_park the same as leisure=sports_centre + sport=swimming, it will not add any additional complications to changing the color in the future.

[imagico]

For reference - the color in question is currently used for

• leisure=recreation_ground and landuse=recreation_ground (but not for leisure=park!)
• leisure=playground
• leisure=fitness_station
• leisure=dog_park
• leisure=sports_centre
• leisure=stadium

[jeisenbe]

Note that leisure=sports_centre and leisure=stadium are still listed under the color @stadium although this now uses @leisure since #2954, and the current light green color was set in #2964.

[jeisenbe]

My plan is to eventually change the @stadium color to be different from @leisure, most likely to a shade of yellow again, or possibly a different earth-tone shade, but I don't believe this will be a problem for leisure=water_park areas.

[jeisenbe]

Any other comments about this PR?

@imagico it's not entirely clear if your review is an approval, or if you would prefer that this not be merged until the @stadium color is changed.

[imagico]

As said i have no specific objections to this change but i don't get the color and how it is used so someone else should evaluate if it makes sense to them.

[jeisenbe]

@imagico reviewed but did not approve or reject this PR. I would be in favor of changing the sports_centre color back to societal_amenities (yellow), though that probably should be a separate PR. Is anyone else willing to review this PR as is?

[polarbearing]

I'd appreciate to join the water_park into the colour of the leisure listed above, thus I'm in favour of this change.
If a colour change for those leisure features is being considered at some stage, it would be done 'en bloc'. However I'd be against using the same colour for leisure as for societal amenities, which are more associated with culture/education.

[jeisenbe]

societal amenities, which are more associated with culture/education

The color is also used for clinics, hospitals, community centres, social facilities (which can be anything from a homeless shelter to an orphanage or a nursning home) and arts centres, hence the general term "societal amenities". A swimming centre, stadium or sports centre can be considered similar to a hospital, community centre, or school in broad landuse category: they are major community destinations, but they are not retail or commercial areas.

[polarbearing]

hence the general term "societal amenities"

I know, I coined the term here in #1624. We should probably open a separate issue for that, I still think that the "societal amenities" should not be overloaded additionally with the "leisure" things.

[jeisenbe]

Rebased for v5.0.0

[pnorman]

Like others I'd prefer to have a different colour for these, but as-is this PR works for me.

[jeisenbe]

Thanks, I will consider fixing the @stadium color soon.