Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't crash lsp server on graphql config errors #2470

Merged
merged 1 commit into from
Jun 3, 2022
Merged

don't crash lsp server on graphql config errors #2470

merged 1 commit into from
Jun 3, 2022

Commits on Jun 3, 2022

  1. fix bug with lsp server crashing on graphql config errors

    Aims to resolve #2421
    
    - graphql config errors only log to output channel, no longer crash the LSP
    - more performant LSP request no-ops for failing/missing config
    
    this used to fail silently in the output channel, but vscode introduced a new retry and notification for this
    
    would like to provide more helpful graphql config DX in the future but this should be better for now
    acao committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    e89be6a View commit details
    Browse the repository at this point in the history