don't crash lsp server on graphql config errors #2470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to resolve #2421
this used to fail silently in the output channel, but vscode introduced a new retry and notification for this. in previous versions of vscode, the server exited non-0, but this didn't cause notifications for the user. this should introduce bugfixes and improvements for non-vscode users of the LSP server as well.
would like to provide more helpful graphql config DX in the future but this should be better for now.
if your LSP server cli implementation needs a non-zero exit for missing/invalid lsp config, let me know and we can add a feature to enable a non-zero failure on config errors for LSP and/or the CLI service wrapper