-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode extension crashing. #2421
Comments
Huh, for some reason, esbuild did not bundle node modules on the last release?? The error you posted shows that it can’t find the module |
Do I need to add graphql-config from npm? |
@lightify97 no you're fine, it's just an issue with how the extension is being bundled before we publish. we are working on a fix, there should be a release today that fixes the problem |
Thanks. |
@lightify97 sorry forgot to post another reply to this yesterday! this bug will go away for you now if you provide a valid graphql config file as in the readme. the issue is that the language server crashes when no I'm currently working on a fix so that it won't do this all the time for users who are opening projects that don't have graphql config present. This error is SO annoying for me as well, because there are many projects I work with that don't have graphql configs present. Currently I have it working so that the server just does nothing when schema isn't present or invalid, but I'm working on getting it to send notifications to the LSP client generically (vscode, vim, sublime, etc) that are permanently dismissible per-workspace that say either that the LSP server is quitting because no config is available, or a warning that it's quitting because the config is invalid and presents the configuration error and perhaps even a link to the the server will exit 0 so as not to invoke the attempts at restarting, as of now it throws an error and exits non-0, which used to not show anything to the user, but in new vscode versions, there are automatic re-tries and all these notifications and it's so annoying! will fix this this week, if not |
@lightify97 sorry forgot to post another reply to this yesterday! this bug will go away for you now if you provide a valid graphql config file as in the readme. the issue is that the language server crashes when no I'm currently working on a fix so that it won't do this all the time for users who are opening projects that don't have graphql config present. This error is SO annoying for me as well, because there are many projects I work with that don't have graphql configs present. Currently I have it working so that the server just does nothing when schema isn't present or invalid, but I'm working on getting it to send notifications to the LSP client generically (vscode, vim, sublime, etc) that are permanently dismissible per-workspace that say either that the LSP server is quitting because no config is available, or a warning that it's quitting because the config is invalid and presents the configuration error and perhaps even a link to the the server will exit 0 so as not to invoke the attempts at restarting, as of now it throws an error and exits non-0, which used to not show anything to the user, but in new vscode versions, there are automatic re-tries and all these notifications and it's so annoying! will fix this this week, if not tonight |
@acao Thanks. Appreciate it. It works with a config file. |
I provided a default config file and the LSP still crashes graphql.config.js
|
Having the same problem. Added a blank config file and now just get a bunch of these errors:
|
@benknight you are getting a graphql config error because you have an empty config file. Please see the docs to learn how to configure. It doesn’t work without a schema defined |
My opinion here is that regardless of any of our invalid or non existent configs the LSP shouldn't crash 5 times. If anything it should gracefully shutdown if there's any errors. Also. I defined a schema and it still crashes. Fortunately or unfortunately I use this extension for graphql highlighting. If I could turn off the LSP I would do so (at least right now) |
If you see the comment above i agree with you and have a fix I’m working on but it will have to wait until I have time to finish it. It used to crash quietly when the config was missing, but a new vscode release makes it restart a bunch of times. I won’t repeat myself any more in this thread lol |
For the sake of other users waiting for a fix, when graphql config is provided, autocompletion works, yes? |
As I also said previously. I provided a config file with a schema and it still crashes with a cryptic error. I appreciate all you are doing here. I'm pretty sure it's something I've done wrong I just can't nail down what it doesn't like that I'm doing. |
I'm having the same problem after updating. Extension v0.4.4 works perfectly, but as soon as I update to v0.4.6 it breaks. I was able to workaround this by going into the extension and downgrading to 0.4.4 (go to the extension, click the down arrow next to "uninstall", choose "Install another version", and select 0.4.4). |
Having the same issue, try to downgrade to
// .graphqlrc.yml
schema: http://localhost:4002
documents: ['**/*.gql']
extensions:
codegen:
generates:
graphql/generated/schema.ts:
config:
maybeValue: T
gqlImport: urql#gql
plugins:
- 'typescript'
- 'typescript-operations'
- 'typescript-urql'
graphql/generated/schema.json:
plugins:
- 'urql-introspection' |
+1
{
"schema": "./src/modules/**/*.graphql"
} Output of the extension is unfortunately useless - no human readable error is provided.] Example log from the output tab
|
- graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
- graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
just cut a pre-release to vscode marketplace |
- graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
- graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
- graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
- graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
Aims to resolve #2421 - graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
Aims to resolve #2421 - graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
Aims to resolve #2421 - graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
released with 0.4.9 stable, there are other issues but this fixes this one for now. thanks for reporting everyone! |
@acao v0.4.9 resolves the issue for me! |
@tm1000 you're very welcome! I was hoping the improved config error reporting would have this effect! |
Aims to resolve #2421 - graphql config errors only log to output channel, no longer crash the LSP - more performant LSP request no-ops for failing/missing config this used to fail silently in the output channel, but vscode introduced a new retry and notification for this would like to provide more helpful graphql config DX in the future but this should be better for now
@acao Good job |
I'm having it all the time today |
The issue regression |
Same here, getting the following error:
Machine:
VSCode:
GraphQL: Language Feature Support
|
Looks like I need to revert the workspaces feature PR, it seems to be causing the server to crash when graphql config is not present, instead of just reporting the bug and disabling language features as was the previous behavior Update: reverting the PR fixed the issue in my local testing. I know how to fix the no-config case bug we introduced in the workspaces PR - the issue is that we accidentally allowed exceptions to bubble up and crash the server, instead of trapping and reporting them. I will re-introduce the workspaces PR, and add more no-config test cases to the language server test suite |
is it fixed in |
@acao sorry for late reply. Yeah it works now. Good job. |
Please Help! I am running next.js on AWS Amplify. error due to server `
so I am running a little blind. thanks in advance. UPDATE: |
IS (auth) CAUSING THE ERROR? the Settings seemed to work partially. IS (auth) CAUSING THE ERROR? |
sorted a few things out but it is still broken... (Auth) folder now seems like the final issue, but it comes with other errors, probably caused by the folder name??? |
The extension keeps crashing in Visual Studio Code.
The text was updated successfully, but these errors were encountered: