The default_value of InputField should be INVALID #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2019
rhizoome
requested review from
changeling,
dan98765,
dvndrsn,
ekampf,
jkimbo,
phalt and
ProjectCheshire
as code owners
Since GraphQL 3.0 there is a distinction between None and INVALID (no value). The tests captured the bug and are updated.
|
@ganwell I've updated your PR to use |
jkimbo
approved these changes
Feb 8, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since GraphQL 3.0 there is a distinction between None and INVALID (no value).
The tests captured the bug and are updated.
See also graphql-python/graphql-core#66 (comment)
I think there are more bugs of this kind, but since I don't know graphene well, yet, I take baby steps.
I could not track the snapshot differences, the order is wrong and master has the same problem too. If master is solved I'll rebase this PR. @jkimbo has the same differences in his commits.