☂️ Graphene v3

[jkimbo]

This issue is to track v3 of Graphene which will contain some breaking changes.

Breaking changes

• Upgrade to graphql-core to v3 which brings feature parity with GraphQL.js v14.6.0
• Drop support for Python v2
• Schema type changes
• "Backends" have been removed
• Switch arguments from type to type_ since type is a builtin: "type" is a builtin in python; switch some arguments called "type" to be "type_" #738
• Upgrade to graphql-core v.3.1 which corresponds to GraphQL.js v15 (will be released soon).
• Change enum behaviour: Improve enum compatibility #1153
• Remove to_const function

TODO

• Write up some proper release notes: https://github.com/graphql-python/graphene/wiki/v3-release-notes
• Merge The default_value of InputField should be INVALID #1111
• Switch arguments from type to type_ since type is a builtin: "type" is a builtin in python; switch some arguments called "type" to be "type_" #738
• Remove to_const function: Remove to_const function #1212
• Change enum behaviour: Improve enum compatibility #1153
• Set minimum graphql-core version to v3.1 Set min version of graphql-core to v3.1.1 #1215
• Upgrade graphene-sqlalchemy to v3 WIP
• Upgrade graphene-mongo to v3 WIP

[dashmug]

May I suggest to use GraphiQL Explorer instead of just GraphiQL?

• https://github.com/OneGraph/graphiql-explorer
• https://github.com/OneGraph/graphiql-explorer-example/tree/master/src

[jkimbo]

@dashmug graphene doesn't specify with version of graphiql you use. All you have to do is host GraphiQL yourself and point it at the grapqhl endpoint and it will work.

[AlecRosenbaum]

What is the release schedule for v3?

It looks like graphene is currently in beta 2, but what other revisions will there be before a non-beta release? How stable is the current beta? For new projects which version should be used?

[radekwlsk]

What is the release schedule for v3?

It looks like graphene is currently in beta 2, but what other revisions will there be before a non-beta release? How stable is the current beta? For new projects which version should be used?

@AlecRosenbaum AFAIK all that is left to do are proper release notes. I was supposed to help with that but unfortunately I couldn't find time for that this week.

If you would like to help feel free to start working on draft of said notes.

I hope to spend some time on that this weekend, but no promises.

[DoctorJohn]

If I interpret the initial comment correctly, the following tasks are left to do (correct me if I'm wrong):

• Merge "type" is a builtin in python; switch some arguments called "type" to be "type_" #738
• Merge Rename resolve_type method #775
• Finish Improve enum compatibility #1153 (?)
• Upgrade to graphql-core v.3.1
• Write up release notes

The master branch being version 3, I guess it's time to merge or properly close #738 and #755. @jkimbo you created on of these PRs and reviewed the other one. Would you mind taking a look at these?

For the graphql-core upgrade, we may need to take a look at their changelog(s) and at graphenes tests.

Last but not least the release notes. I'd imagine them similar to the previous ones (v1, v2). They should cover all changes listed in the initial issue. One might need to look trough v3 commits to properly cover schema type changes.

[jkimbo]

@DoctorJohn I came to the conclusion that #775 is not actually needed (reasons here: #775 (comment)). Also #738 needs to be brought up to date with master because it's quite old. @radekwlsk @DoctorJohn if either of you could help with that that would be great.

Other than that that list looks right, I've updated the description to include them.

[jkimbo]

Also I'm going to try and find some time this week to finish #1153 but no promises unfortunately.

[jkimbo]

#1153 is ready for review now. If anyone has the time to take a look it would be most appreciated.