Skip to content

"type" is a builtin in python; switch some arguments called "type" to be "type_" #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dan98765
Copy link
Contributor

@dan98765 dan98765 commented May 25, 2018

Closes #700

Also:

  • Underscore prefix generally is understood to mean 'private' more than just 'not a builtin' so changed type to type to be consistent.
  • Add aniso8601 dep to tox.ini to get tests to pass

@dan98765 dan98765 force-pushed the append_underscore_to_type_arg branch from 8cff4f3 to b89e2c3 Compare May 28, 2018 22:00
@dan98765
Copy link
Contributor Author

@jkimbo how do you feel about this branch?

Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. It's technically a breaking change so lets try and get it in 2.2 with the _resolve_type change as well.

@jkimbo jkimbo requested a review from syrusakbary June 24, 2018 19:25
@morenoh149
Copy link
Contributor

@dan98765 needs rebase

@jkimbo
Copy link
Member

jkimbo commented Mar 8, 2019

Since it’s a breaking change it should probably be part of a 3.0 release (instead of 2.2 as I suggested earlier). Do you agree @graphql-python/governors ?

@Cito
Copy link
Member

Cito commented Mar 11, 2019

@jkimbo I'm also using type_ instead of type in graphql-core-next, so this would be consistent.

Copy link
Member

@mvanlonden mvanlonden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but wait until ready for 3.0 release, should be merged alongside #775

@jkimbo jkimbo added the breaking change Pull requests that introduce a breaking change label Mar 16, 2019
@ProjectCheshire ProjectCheshire added the 3.0 Fix/Release version 3.0 label Jun 2, 2019
@stale
Copy link

stale bot commented Jul 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 29, 2019
@jkimbo jkimbo removed the wontfix label Jul 30, 2019
@stale
Copy link

stale bot commented Sep 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 27, 2019
@stale stale bot closed this Oct 4, 2019
@jkimbo jkimbo mentioned this pull request Jan 29, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Fix/Release version 3.0 breaking change Pull requests that introduce a breaking change wontfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query cannot have a field named 'type'
6 participants