-
Notifications
You must be signed in to change notification settings - Fork 822
"type" is a builtin in python; switch some arguments called "type" to be "type_" #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"type" is a builtin in python; switch some arguments called "type" to be "type_" #738
Conversation
8cff4f3
to
b89e2c3
Compare
@jkimbo how do you feel about this branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. It's technically a breaking change so lets try and get it in 2.2 with the _resolve_type
change as well.
@dan98765 needs rebase |
Since it’s a breaking change it should probably be part of a 3.0 release (instead of 2.2 as I suggested earlier). Do you agree @graphql-python/governors ? |
@jkimbo I'm also using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but wait until ready for 3.0 release, should be merged alongside #775
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closes #700
Also:
aniso8601
dep to tox.ini to get tests to pass